[GitHub] [flink] hequn8128 opened a new pull request #9248: [FLINK-13446][table-runtime-blink] Fix assign logic for row count sliding window

[GitBox <gi...@apache.org>]

hequn8128 opened a new pull request #9248: [FLINK-13446][table-runtime-blink] Fix assign logic for row count sliding window
URL: https://github.com/apache/flink/pull/9248
 
 
   
   ## What is the purpose of the change
   
   For blink planner, the Row count sliding window outputs incorrectly. The window assigner assigns less window than what expected. This means the window outputs fewer data. 
   
   This pull request fixes the window assigner and trigger logic, i.e., correct the window start and end calculation. 
   
   
   ## Brief change log
   
     - Add trigger size property to `CountWindow`, because in some cases, the count window fires with a trigger size less than the window size.
     - Correct the window start and end calculation in `CountSlidingWindowAssigner`. 
     - Correct existing test cases.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as GroupWindowITCase and WindowOperatorTest.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services