You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Joseph K. Bradley (JIRA)" <ji...@apache.org> on 2016/11/28 20:34:58 UTC
[jira] [Commented] (SPARK-18613) spark.ml LDA classes should not
expose spark.mllib in APIs
[ https://issues.apache.org/jira/browse/SPARK-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703047#comment-15703047 ]
Joseph K. Bradley commented on SPARK-18613:
-------------------------------------------
CC [~yuhaoyan]
> spark.ml LDA classes should not expose spark.mllib in APIs
> ----------------------------------------------------------
>
> Key: SPARK-18613
> URL: https://issues.apache.org/jira/browse/SPARK-18613
> Project: Spark
> Issue Type: Improvement
> Components: ML
> Reporter: Joseph K. Bradley
> Priority: Critical
>
> spark.ml.LDAModel exposes dependencies on spark.mllib in 2 methods, but it should not:
> * {{def oldLocalModel: OldLocalLDAModel}}
> * {{def getModel: OldLDAModel}}
> This task is to deprecate those methods. I recommend creating {{private[ml]}} versions of the methods which are used internally in order to avoid deprecation warnings.
> Setting target for 2.2, but I'm OK with getting it into 2.1 if we have time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org