[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5750: use physical size instead of virtual size for migration.

[GitBox <gi...@apache.org>]

Pearl1594 commented on a change in pull request #5750:
URL: https://github.com/apache/cloudstack/pull/5750#discussion_r778685136



##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/StorageOrchestrator.java
##########
@@ -194,8 +197,9 @@ public MigrationResponse migrateData(Long srcDataStoreId, List<Long> destDatasto
                 destDatastoreId = orderedDS.get(1);
             }
 
-            if (chosenFileForMigration.getSize() > storageCapacities.get(destDatastoreId).first()) {
-                s_logger.debug("file: " + chosenFileForMigration.getId() + " too large to be migrated to " + destDatastoreId);
+            if (chosenFileForMigration.getPhysicalSize() > storageCapacities.get(destDatastoreId).first()) {
+                s_logger.debug(String.format("%s: %s too large to be migrated to %s", getObjectType(chosenFileForMigration), chosenFileForMigration.getUuid(), destDatastoreId));
+                skipped += 1;
                 continue;

Review comment:
       I tried moving one of the child templates of a multi-disk template to another store and modified the store_id details in the template_store_ref table and noticed a failure during deletion of the template, where it complained about not being able to find the template.  cc @DaanHoogland @nvazquez 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org