You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/06 16:08:58 UTC
[jira] [Commented] (QUICKSTEP-65) Quickstep fails to build on Mac
OSX 10.12
[ https://issues.apache.org/jira/browse/QUICKSTEP-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725917#comment-15725917 ]
ASF GitHub Bot commented on QUICKSTEP-65:
-----------------------------------------
GitHub user saketj opened a pull request:
https://github.com/apache/incubator-quickstep/pull/153
QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12
Quickstep build on Mac OSX 10.12 fails due to deprecation of certain system APIs in the new OSX version. The Quickstep code does not rely on these deprecated APIs, but it is the protobuf library which uses these deprecated APIs. [See: https://github.com/google/protobuf/issues/2182]
Although, this has been resolved in the latest master of protobuf [See: https://github.com/google/protobuf/pull/2337], Quickstep protobuf cmake integration file has to be updated resolve this.
As this is turning out to be a blocker for the dev environment, this JIRA proposes a quick short-term fix for this issue by specifically turning off deprecation errors on OSX 10.12 platform. The more stable long-term fix would be to port the protobuf_cmake to the newest protobuf version. However, that requires some non-trivial effort and will be done through a separate JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saketj/incubator-quickstep fix-osx-build-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit 6ae0cdd3d5db40febc98be00ce94baeed31ba680
Author: Saket Saurabh <ss...@cs.wisc.edu>
Date: 2016-12-06T15:53:57Z
QUICKSTEP-65 Fix Quickstep build failure on Mac OSX 10.12 by turning off deprecation errors
----
> Quickstep fails to build on Mac OSX 10.12
> -----------------------------------------
>
> Key: QUICKSTEP-65
> URL: https://issues.apache.org/jira/browse/QUICKSTEP-65
> Project: Apache Quickstep
> Issue Type: Bug
> Reporter: Saket Saurabh
>
> Quickstep build on Mac OSX 10.12 fails due to deprecation of certain system APIs in the new OSX version. The Quickstep code does not rely on these deprecated APIs, but it is the protobuf library which uses these deprecated APIs. [See: https://github.com/google/protobuf/issues/2182]
> Although, this has been resolved in the latest master of protobuf [See: https://github.com/google/protobuf/pull/2337], Quickstep protobuf cmake integration file has to be updated resolve this.
> As this is turning out to be a blocker for the dev environment, this JIRA proposes a quick short-term fix for this issue by specifically turning off deprecation errors on OSX 10.12 platform. The more stable long-term fix would be to port the protobuf_cmake to the newest protobuf version. However, that requires some non-trivial effort and will be done through a separate JIRA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)