[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9247: [Improvement][style]add comment and clear warn

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #9247:
URL: https://github.com/apache/dolphinscheduler/pull/9247#discussion_r854748746


##########
dolphinscheduler-alert/dolphinscheduler-alert-api/src/main/java/org/apache/dolphinscheduler/alert/api/AlertData.java:
##########
@@ -102,42 +108,41 @@ public boolean equals(final Object o) {
         if (this.getWarnType() != other.getWarnType()) {
             return false;
         }
-        final Object this$title = this.getTitle();
-        final Object other$title = other.getTitle();
-        if (this$title == null ? other$title != null : !this$title.equals(other$title)) {
-            return false;
-        }
-        final Object this$content = this.getContent();
-        final Object other$content = other.getContent();
-        if (this$content == null ? other$content != null : !this$content.equals(other$content)) {
+        final Object thisTitle = this.getTitle();
+        final Object otherTitle = other.getTitle();
+        if (!Objects.equals(thisTitle, otherTitle)) {

Review Comment:
   Good job!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org