You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/21 09:53:21 UTC
[GitHub] [dubbo-go] oaoit opened a new pull request #767: add multi docs
oaoit opened a new pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
add multi docs
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767#issuecomment-696110055
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=h1) Report
> Merging [#767](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) will **decrease** coverage by `3.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #767 +/- ##
===========================================
- Coverage 63.75% 59.90% -3.86%
===========================================
Files 239 259 +20
Lines 12796 12722 -74
===========================================
- Hits 8158 7621 -537
- Misses 3849 4149 +300
- Partials 789 952 +163
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (-22.30%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `75.58% <0.00%> (-16.26%)` | :arrow_down: |
| [...a/service/remote/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvbWV0YWRhdGFfc2VydmljZV9wcm94eV9mYWN0b3J5Lmdv) | `25.00% <0.00%> (-15.00%)` | :arrow_down: |
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `60.00% <0.00%> (-11.43%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-11.32%)` | :arrow_down: |
| [...nstance/random/random\_service\_instance\_selector.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9pbnN0YW5jZS9yYW5kb20vcmFuZG9tX3NlcnZpY2VfaW5zdGFuY2Vfc2VsZWN0b3IuZ28=) | `55.55% <0.00%> (-11.12%)` | :arrow_down: |
| [metadata/identifier/service\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-bWV0YWRhdGEvaWRlbnRpZmllci9zZXJ2aWNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `20.00% <0.00%> (-10.77%)` | :arrow_down: |
| ... and [256 more](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=footer). Last update [811f4f1...6918587](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767#issuecomment-696110055
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=h1) Report
> Merging [#767](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/811f4f1a2dcc75b4294f62cb795da0f3f399be93?el=desc) will **decrease** coverage by `3.85%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #767 +/- ##
===========================================
- Coverage 63.75% 59.90% -3.86%
===========================================
Files 239 259 +20
Lines 12796 12722 -74
===========================================
- Hits 8158 7621 -537
- Misses 3849 4149 +300
- Partials 789 952 +163
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `63.41% <0.00%> (-22.30%)` | :arrow_down: |
| [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `50.00% <0.00%> (-16.67%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `75.58% <0.00%> (-16.26%)` | :arrow_down: |
| [...a/service/remote/metadata\_service\_proxy\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvbWV0YWRhdGFfc2VydmljZV9wcm94eV9mYWN0b3J5Lmdv) | `25.00% <0.00%> (-15.00%)` | :arrow_down: |
| [config\_center/nacos/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWN0b3J5Lmdv) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [config\_center/zookeeper/factory.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvZmFjdG9yeS5nbw==) | `50.00% <0.00%> (-12.50%)` | :arrow_down: |
| [common/extension/metrics.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRyaWNzLmdv) | `60.00% <0.00%> (-11.43%)` | :arrow_down: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-11.32%)` | :arrow_down: |
| [...nstance/random/random\_service\_instance\_selector.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9pbnN0YW5jZS9yYW5kb20vcmFuZG9tX3NlcnZpY2VfaW5zdGFuY2Vfc2VsZWN0b3IuZ28=) | `55.55% <0.00%> (-11.12%)` | :arrow_down: |
| [metadata/identifier/service\_metadata\_identifier.go](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree#diff-bWV0YWRhdGEvaWRlbnRpZmllci9zZXJ2aWNlX21ldGFkYXRhX2lkZW50aWZpZXIuZ28=) | `20.00% <0.00%> (-10.77%)` | :arrow_down: |
| ... and [256 more](https://codecov.io/gh/apache/dubbo-go/pull/767/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=footer). Last update [811f4f1...6918587](https://codecov.io/gh/apache/dubbo-go/pull/767?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo merged pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
watermelo merged pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767#discussion_r491945929
##########
File path: doc/md/hessian2/dubbo-go-hessian2-performance-optimization.md
##########
@@ -0,0 +1,233 @@
+# [记一次对 dubbo-go-hessian2 的性能优化](https://gocn.vip/topics/10339)
Review comment:
delete gocn.
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
Review comment:
delete jianshu.com
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
+
+而[dubbogo](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go)则是dubbo的go语言实现。
Review comment:
delete jianshu.com
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
+
+而[dubbogo](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go)则是dubbo的go语言实现。
+
+最近在`dubbogo`的`todo list`上发现,它还没有实现`TPS Limit`的模块,于是就抽空实现了这个部分。
+
+`TPS limit`实际上就是限流,比如说限制一分钟内某个接口只能访问200次,超过这个次数,则会被拒绝服务。在`Dubbo`的Java版本上,只有一个实现,就是`DefaultTPSLimiter`。
+
+`DefaultTPSLimiter`是在服务级别上进行限流。虽然`dubbo`的官方文档里面声称可以在`method`级别上进行限流,但是我看了一下它的源码,实际上这个是做不到的。当然,如果自己通过实现`Filter`接口来实现`method`级别的限流,那么自然是可以的——这样暴露了`dubbo`Java版本实现的另外一个问题,就是`dubbo`的`TpsLimitFilter`实现,是不允许接入自己`TpsLimiter`的实现的。这从它的源码也可以看出来:
+
+
+
+它直接写死了`TpsLimiter`的实现。
+
+这个实现的目前只是合并到了`develop`上,等下次发布正式版本的时候才会发布出来。
+
+Github: [https://github.com/apache/dubbo-go/pull/237](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go%2Fpull%2F237)
Review comment:
delete jianshu.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767#discussion_r491945929
##########
File path: doc/md/hessian2/dubbo-go-hessian2-performance-optimization.md
##########
@@ -0,0 +1,233 @@
+# [记一次对 dubbo-go-hessian2 的性能优化](https://gocn.vip/topics/10339)
Review comment:
delete gocn.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] watermelo merged pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
watermelo merged pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #767: Add: dubbogo docs
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #767:
URL: https://github.com/apache/dubbo-go/pull/767#discussion_r491946773
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
Review comment:
delete jianshu.com
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
+
+而[dubbogo](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go)则是dubbo的go语言实现。
Review comment:
delete jianshu.com
##########
File path: doc/md/service-governance/dubbo-go-tps-limit-design-and-implement.md
##########
@@ -0,0 +1,163 @@
+# [dubbogo中的TPS Limit设计与实现](https://www.jianshu.com/p/5e4d490f163c)
+
+# 前言
+
+[Apache Dubbo](https://links.jianshu.com/go?to=http%3A%2F%2Fdubbo.apache.org%2Fen-us%2F)是由阿里开源的一个RPC框架,除了基本的RPC功能以外,还提供了一整套的服务治理相关功能。目前它已经是Apache基金会下的顶级项目。
+
+而[dubbogo](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go)则是dubbo的go语言实现。
+
+最近在`dubbogo`的`todo list`上发现,它还没有实现`TPS Limit`的模块,于是就抽空实现了这个部分。
+
+`TPS limit`实际上就是限流,比如说限制一分钟内某个接口只能访问200次,超过这个次数,则会被拒绝服务。在`Dubbo`的Java版本上,只有一个实现,就是`DefaultTPSLimiter`。
+
+`DefaultTPSLimiter`是在服务级别上进行限流。虽然`dubbo`的官方文档里面声称可以在`method`级别上进行限流,但是我看了一下它的源码,实际上这个是做不到的。当然,如果自己通过实现`Filter`接口来实现`method`级别的限流,那么自然是可以的——这样暴露了`dubbo`Java版本实现的另外一个问题,就是`dubbo`的`TpsLimitFilter`实现,是不允许接入自己`TpsLimiter`的实现的。这从它的源码也可以看出来:
+
+
+
+它直接写死了`TpsLimiter`的实现。
+
+这个实现的目前只是合并到了`develop`上,等下次发布正式版本的时候才会发布出来。
+
+Github: [https://github.com/apache/dubbo-go/pull/237](https://links.jianshu.com/go?to=https%3A%2F%2Fgithub.com%2Fapache%2Fdubbo-go%2Fpull%2F237)
Review comment:
delete jianshu.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org