You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2006/10/24 23:29:16 UTC

[jira] Created: (JCR-602) importXML still depends on Xerces

importXML still depends on Xerces
---------------------------------

                 Key: JCR-602
                 URL: http://issues.apache.org/jira/browse/JCR-602
             Project: Jackrabbit
          Issue Type: Bug
          Components: xml
    Affects Versions: 1.1
            Reporter: Jukka Zitting
            Priority: Minor


Przemo Pakulski commented on JCR-367:
> Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> Workspacempl.importWorkspace methods contains folliwng lines :
>
>             XMLReader parser =
>                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
>
> It works in maven1 probably because maven1 itself needs xerces to run test goal.
>
> I suggest reopening the issue.

Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting resolved JCR-602.
-------------------------------

    Resolution: Fixed

Applied the patch revision 468956.

That should be the last Xerces dependency, at least a grep for "xerces" didn't bring out any new issues. Resolving as Fixed.


> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml, JCR TCK
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>         Attachments: XercesTestCases.patch
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting updated JCR-602:
------------------------------

    Component/s: JCR TCK

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml, JCR TCK
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>         Attachments: XercesTestCases.patch
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting updated JCR-602:
------------------------------

    Attachment: XercesTestCases.patch

Attached a patch that removes the Xerces dependency from the mentioned test cases.

Note that I also replaced a number of long throws clauses with a simple "throws Exception" to avoid adding another exception (ParserConfigurationException) to the list. This shouldn't be a problem since the only recipient of the exceptions is the unit test framework  that doesn't really care about the type of the exception.

I'm a bit worried about making direct changes to the TCK codebase, so could someone who's more involved with the TCK quickly review the patch before I commit it? I don't see any problems as the change should have no functional effects, I just want to make sure I don't accidentally mess with something important.

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml, JCR TCK
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>         Attachments: XercesTestCases.patch
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (JCR-602) importXML still depends on Xerces

Posted by "Przemo Pakulski (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/JCR-602?page=comments#action_12444603 ] 
            
Przemo Pakulski commented on JCR-602:
-------------------------------------

There are still tests dependent on Xercec in org.apache.jackrabbit.test.api package :
- AbstractImportXmlTest
- SerializationTest
It will be nice to remove dependency from tests too.

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting reassigned JCR-602:
---------------------------------

    Assignee: Jukka Zitting

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting resolved JCR-602.
-------------------------------

    Fix Version/s: 1.1.1
       Resolution: Fixed

Fixed in revision 467501. Thanks for reporting this!

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (JCR-602) importXML still depends on Xerces

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/JCR-602?page=all ]

Jukka Zitting reopened JCR-602:
-------------------------------

             
Agreed; thanks for the update! Reopened.

> importXML still depends on Xerces
> ---------------------------------
>
>                 Key: JCR-602
>                 URL: http://issues.apache.org/jira/browse/JCR-602
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: xml
>    Affects Versions: 1.1
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1.1
>
>
> Przemo Pakulski commented on JCR-367:
> > Jackrabbit-core is still dependent on Xerces directly during runtime, SessionImpl.importWorkspace,
> > Workspacempl.importWorkspace methods contains folliwng lines :
> >
> >             XMLReader parser =
> >                     XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
> >
> > It works in maven1 probably because maven1 itself needs xerces to run test goal.
> >
> > I suggest reopening the issue.
> Creating a new issue since JCR-367 is already closed after the 1.1 release.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira