You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/22 17:49:52 UTC

[kyuubi] branch branch-1.7 updated: [KYUUBI #4399] Remove redundant config in Trino frontend

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/branch-1.7 by this push:
     new cb8431b5e [KYUUBI #4399] Remove redundant config in Trino frontend
cb8431b5e is described below

commit cb8431b5e3ca3a66542b360d5145bfceef259e55
Author: edddddy <rm...@qq.com>
AuthorDate: Thu Feb 23 01:49:24 2023 +0800

    [KYUUBI #4399] Remove redundant config in Trino frontend
    
    ### _Why are the changes needed?_
    
    It seems to be redundant to keep these configurations in the Trino frontend module. Thus, to my mind, removing them make things better.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4399 from edddddy/master.
    
    Closes #4399
    
    81dab6b2 [edddddy] remove some redundant config in Trino front-end
    
    Authored-by: edddddy <rm...@qq.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
    (cherry picked from commit e4d0962d5dd6b5fcf1599b633dcd0597bc4491cd)
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../org/apache/kyuubi/server/KyuubiTrinoFrontendService.scala    | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTrinoFrontendService.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTrinoFrontendService.scala
index fca8b8a87..573bb948f 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTrinoFrontendService.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiTrinoFrontendService.scala
@@ -64,15 +64,6 @@ class KyuubiTrinoFrontendService(override val serverable: Serverable)
   private def startInternal(): Unit = {
     val contextHandler = ApiRootResource.getServletHandler(this)
     server.addHandler(contextHandler)
-
-    server.addStaticHandler("org/apache/kyuubi/ui/static", "/static/")
-    server.addRedirectHandler("/", "/static/")
-    server.addRedirectHandler("/static", "/static/")
-    server.addStaticHandler("META-INF/resources/webjars/swagger-ui/4.9.1/", "/swagger-static/")
-    server.addStaticHandler("org/apache/kyuubi/ui/swagger", "/swagger/")
-    server.addRedirectHandler("/docs", "/swagger/")
-    server.addRedirectHandler("/docs/", "/swagger/")
-    server.addRedirectHandler("/swagger", "/swagger/")
   }
 
   override def start(): Unit = synchronized {