You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/06/28 05:43:42 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #109: More coverage
atoulme opened a new pull request #109:
URL: https://github.com/apache/incubator-tuweni/pull/109
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
More coverage!
<!-- Please link to fixed issue(s) here using format: fixes #<issue number> -->
<!-- Example: "fixes #2" -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #109: More coverage
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #109:
URL: https://github.com/apache/incubator-tuweni/pull/109#issuecomment-650701566
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=h1) Report
> Merging [#109](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3a060d4883f1d371ab8c27de40b4d71e1635d55f&el=desc) will **decrease** coverage by `4.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #109 +/- ##
============================================
- Coverage 59.43% 54.84% -4.59%
+ Complexity 3988 565 -3423
============================================
Files 391 132 -259
Lines 19895 5417 -14478
Branches 2412 582 -1830
============================================
- Hits 11824 2971 -8853
+ Misses 6806 2133 -4673
+ Partials 1265 313 -952
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `54.84% <ø> (ø)` | `565.00 <ø> (ø)` | |
| #unit | `?` | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../main/java/org/apache/tuweni/ethstats/TxStats.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9UeFN0YXRzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../kotlin/org/apache/tuweni/devp2p/v5/PacketCodec.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvUGFja2V0Q29kZWMua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...n/java/org/apache/tuweni/ethstats/AuthMessage.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZXRoc3RhdHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ldGhzdGF0cy9BdXRoTWVzc2FnZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...rg/apache/tuweni/devp2p/v5/packet/TicketMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1RpY2tldE1lc3NhZ2Uua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../apache/tuweni/devp2p/v5/packet/RegTopicMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ1RvcGljTWVzc2FnZS5rdA==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-7.00%)` | |
| [...ava/org/apache/tuweni/scuttlebutt/rpc/RPCFlag.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0ZsYWcuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/devp2p/v5/packet/TopicQueryMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1RvcGljUXVlcnlNZXNzYWdlLmt0) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../tuweni/devp2p/v5/packet/RegConfirmationMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ0NvbmZpcm1hdGlvbk1lc3NhZ2Uua3Q=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...weni/scuttlebutt/handshake/HandshakeException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL0hhbmRzaGFrZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ebutt/handshake/SecureScuttlebuttStreamServer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL1NlY3VyZVNjdXR0bGVidXR0U3RyZWFtU2VydmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `1.00% <0.00%> (-2.00%)` | |
| ... and [302 more](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=footer). Last update [3a060d4...db1048d](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #109: More coverage
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #109:
URL: https://github.com/apache/incubator-tuweni/pull/109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #109: More coverage
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #109:
URL: https://github.com/apache/incubator-tuweni/pull/109#issuecomment-650701566
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=h1) Report
> Merging [#109](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/3a060d4883f1d371ab8c27de40b4d71e1635d55f&el=desc) will **increase** coverage by `0.78%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #109 +/- ##
============================================
+ Coverage 59.43% 60.22% +0.78%
- Complexity 3988 4030 +42
============================================
Files 391 391
Lines 19895 19895
Branches 2412 2412
============================================
+ Hits 11824 11981 +157
+ Misses 6806 6615 -191
- Partials 1265 1299 +34
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `54.84% <ø> (ø)` | `565.00 <ø> (ø)` | |
| #unit | `53.68% <ø> (+0.83%)` | `3762.00 <ø> (+43.00)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/tuweni/crypto/sodium/Sodium.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9Tb2RpdW0uamF2YQ==) | `26.50% <0.00%> (+0.78%)` | `152.00% <0.00%> (+6.00%)` | |
| [.../org/apache/tuweni/crypto/sodium/DiffieHelman.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9EaWZmaWVIZWxtYW4uamF2YQ==) | `42.85% <0.00%> (+1.90%)` | `0.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/tuweni/toml/JsonSerializer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-dG9tbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3RvbWwvSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `81.52% <0.00%> (+3.26%)` | `27.00% <0.00%> (+1.00%)` | |
| [...src/main/java/org/apache/tuweni/bytes/Bytes48.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczQ4LmphdmE=) | `42.85% <0.00%> (+10.20%)` | `11.00% <0.00%> (+3.00%)` | |
| [...src/main/java/org/apache/tuweni/bytes/Bytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9CeXRlczMyLmphdmE=) | `51.06% <0.00%> (+10.63%)` | `12.00% <0.00%> (+3.00%)` | |
| [.../org/apache/tuweni/bytes/ArrayWrappingBytes32.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9BcnJheVdyYXBwaW5nQnl0ZXMzMi5qYXZh) | `53.33% <0.00%> (+13.33%)` | `4.00% <0.00%> (+2.00%)` | |
| [.../org/apache/tuweni/bytes/ArrayWrappingBytes48.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Ynl0ZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9ieXRlcy9BcnJheVdyYXBwaW5nQnl0ZXM0OC5qYXZh) | `53.33% <0.00%> (+13.33%)` | `4.00% <0.00%> (+2.00%)` | |
| [...ain/java/org/apache/tuweni/crypto/sodium/Auth.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9BdXRoLmphdmE=) | `50.00% <0.00%> (+14.58%)` | `3.00% <0.00%> (ø%)` | |
| [...rc/main/java/org/apache/tuweni/toml/TomlArray.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-dG9tbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3RvbWwvVG9tbEFycmF5LmphdmE=) | `50.00% <0.00%> (+37.50%)` | `11.00% <0.00%> (+8.00%)` | |
| [...a/org/apache/tuweni/crypto/sodium/KeyExchange.java](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree#diff-Y3J5cHRvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY3J5cHRvL3NvZGl1bS9LZXlFeGNoYW5nZS5qYXZh) | `39.46% <0.00%> (+39.46%)` | `2.00% <0.00%> (+2.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-tuweni/pull/109/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=footer). Last update [3a060d4...db1048d](https://codecov.io/gh/apache/incubator-tuweni/pull/109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org