You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by an...@apache.org on 2014/07/15 23:55:19 UTC

svn commit: r1610862 [21/44] - in /tomee/tomee/trunk/itests: ./ failover-ejb/ failover-ejb/src/main/java/org/apache/openejb/itest/failover/ejb/ failover/ failover/src/main/java/org/apache/openejb/itest/failover/ failover/src/main/java/org/apache/openej...

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpContextLookupTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpContextLookupTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpContextLookupTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpContextLookupTests.java Tue Jul 15 21:55:09 2014
@@ -20,28 +20,27 @@ import org.apache.openejb.test.TestFailu
 
 /**
  * [4] Should be run as the fourth test suite of the EncBmpTestClients
- *
  */
-public class BmpContextLookupTests extends BmpTestClient{
+public class BmpContextLookupTests extends BmpTestClient {
 
-    protected EncBmpHome   ejbHome;
+    protected EncBmpHome ejbHome;
     protected EncBmpObject ejbObject;
 
-    public BmpContextLookupTests(){
+    public BmpContextLookupTests() {
         super("JNDI_ENC.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/ContextLookupBmpBean");
-        ejbHome = (EncBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, EncBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/ContextLookupBmpBean");
+        ejbHome = (EncBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, EncBmpHome.class);
         ejbObject = ejbHome.create("Enc Bean");
     }
 
     protected void tearDown() throws Exception {
         try {
             //ejbObject.remove();
-        } catch (Exception e){
+        } catch (final Exception e) {
             throw e;
         } finally {
             super.tearDown();
@@ -49,162 +48,162 @@ public class BmpContextLookupTests exten
     }
 
     public void test01_lookupStringEntry() {
-        try{
+        try {
             ejbObject.lookupStringEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test02_lookupDoubleEntry() {
-        try{
+        try {
             ejbObject.lookupDoubleEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test03_lookupLongEntry() {
-        try{
+        try {
             ejbObject.lookupLongEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test04_lookupFloatEntry() {
-        try{
+        try {
             ejbObject.lookupFloatEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test05_lookupIntegerEntry() {
-        try{
+        try {
             ejbObject.lookupIntegerEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test06_lookupShortEntry() {
-        try{
+        try {
             ejbObject.lookupShortEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test07_lookupBooleanEntry() {
-        try{
+        try {
             ejbObject.lookupBooleanEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test08_lookupByteEntry() {
-        try{
+        try {
             ejbObject.lookupByteEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test09_lookupCharacterEntry() {
-        try{
+        try {
             ejbObject.lookupCharacterEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test10_lookupEntityBean() {
-        try{
+        try {
             ejbObject.lookupEntityBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test11_lookupStatefulBean() {
-        try{
+        try {
             ejbObject.lookupStatefulBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test12_lookupStatelessBean() {
-        try{
+        try {
             ejbObject.lookupStatelessBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test13_lookupResource() {
-        try{
+        try {
             ejbObject.lookupResource();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test14_lookupPersistenceUnit() {
-        try{
+        try {
             ejbObject.lookupPersistenceUnit();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test15_lookupPersistenceContext() {
-        try{
+        try {
             ejbObject.lookupPersistenceContext();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test23_lookupJMSConnectionFactory() {
-        try{
+        try {
             ejbObject.lookupJMSConnectionFactory();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 }

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbHomeTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbHomeTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbHomeTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbHomeTests.java Tue Jul 15 21:55:09 2014
@@ -21,18 +21,17 @@ import javax.ejb.ObjectNotFoundException
 
 /**
  * [3] Should be run as the third test suite of the BasicBmpTestClients
- *
  */
-public class BmpEjbHomeTests extends BasicBmpTestClient{
+public class BmpEjbHomeTests extends BasicBmpTestClient {
 
-    public BmpEjbHomeTests(){
+    public BmpEjbHomeTests() {
         super("EJBHome.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbObject = ejbHome.createObject("Second Bean");
         ejbPrimaryKey = ejbObject.getPrimaryKey();
     }
@@ -40,26 +39,26 @@ public class BmpEjbHomeTests extends Bas
     //===============================
     // Test ejb home methods
     //
-    public void test01_getEJBMetaData(){
-        try{
-        EJBMetaData ejbMetaData = ejbHome.getEJBMetaData();
-        assertNotNull( "The EJBMetaData is null", ejbMetaData );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test01_getEJBMetaData() {
+        try {
+            final EJBMetaData ejbMetaData = ejbHome.getEJBMetaData();
+            assertNotNull("The EJBMetaData is null", ejbMetaData);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test02_getHomeHandle(){
-        try{
+    public void test02_getHomeHandle() {
+        try {
             ejbHomeHandle = ejbHome.getHomeHandle();
-            assertNotNull( "The HomeHandle is null", ejbHomeHandle );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+            assertNotNull("The HomeHandle is null", ejbHomeHandle);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test03_removeByPrimaryKey(){
-        try{
+    public void test03_removeByPrimaryKey() {
+        try {
             // remove the ejb
             ejbHome.remove(ejbPrimaryKey);
 
@@ -67,27 +66,27 @@ public class BmpEjbHomeTests extends Bas
             try {
                 ejbHome.findByPrimaryKey((Integer) ejbPrimaryKey);
                 fail("Entity was not actually removed");
-            } catch (ObjectNotFoundException e) {
+            } catch (final ObjectNotFoundException e) {
             }
 
             // verify the proxy is dead
-            try{
+            try {
                 ejbObject.businessMethod("Should throw an exception");
-                assertTrue( "Calling business method after removing the EJBObject does not throw an exception", false );
-            } catch (Exception e){
+                assertTrue("Calling business method after removing the EJBObject does not throw an exception", false);
+            } catch (final Exception e) {
             }
 
             // create a new ejb for the next test
             ejbObject = ejbHome.createObject("Second Bean");
             ejbPrimaryKey = ejbObject.getPrimaryKey();
-        } catch (Exception e){
+        } catch (final Exception e) {
             e.printStackTrace();
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test04_removeByPrimaryHandle(){
-        try{
+    public void test04_removeByPrimaryHandle() {
+        try {
             // remove the ejb
             ejbHome.remove(ejbObject.getHandle());
 
@@ -95,29 +94,29 @@ public class BmpEjbHomeTests extends Bas
             try {
                 ejbHome.findByPrimaryKey((Integer) ejbPrimaryKey);
                 fail("Entity was not actually removed");
-            } catch (ObjectNotFoundException e) {
+            } catch (final ObjectNotFoundException e) {
             }
 
             // verify the proxy is dead
-            try{
+            try {
                 ejbObject.businessMethod("Should throw an exception");
-                assertTrue( "Calling business method after removing the EJBObject does not throw an exception", false );
-            } catch (Exception e){
+                assertTrue("Calling business method after removing the EJBObject does not throw an exception", false);
+            } catch (final Exception e) {
             }
 
             // create a new ejb for the next test
             ejbObject = ejbHome.createObject("Second Bean");
             ejbPrimaryKey = ejbObject.getPrimaryKey();
-        } catch (Exception e){
+        } catch (final Exception e) {
             e.printStackTrace();
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test05_ejbHomeMethod() {
         try {
-            assertEquals(8+9, ejbHome.sum(8, 9));
-        } catch (Throwable e) {
+            assertEquals(8 + 9, ejbHome.sum(8, 9));
+        } catch (final Throwable e) {
             e.printStackTrace();
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbMetaDataTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbMetaDataTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbMetaDataTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbMetaDataTests.java Tue Jul 15 21:55:09 2014
@@ -20,76 +20,75 @@ import javax.ejb.EJBHome;
 
 /**
  * [8] Should be run as the eigth test suite of the BasicBmpTestClients
- *
  */
-public class BmpEjbMetaDataTests extends BasicBmpTestClient{
+public class BmpEjbMetaDataTests extends BasicBmpTestClient {
 
-    public BmpEjbMetaDataTests(){
+    public BmpEjbMetaDataTests() {
         super("EJBMetaData.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbMetaData = ejbHome.getEJBMetaData();
     }
 
     //=================================
     // Test meta data methods
     //
-    public void test01_getEJBHome(){
-        try{
-        EJBHome home = ejbMetaData.getEJBHome();
-        assertNotNull( "The EJBHome is null", home );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test01_getEJBHome() {
+        try {
+            final EJBHome home = ejbMetaData.getEJBHome();
+            assertNotNull("The EJBHome is null", home);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test02_getHomeInterfaceClass(){
-        try{
-        Class clazz = ejbMetaData.getHomeInterfaceClass();
-        assertNotNull( "The Home Interface class is null", clazz );
-        assertEquals(clazz , BasicBmpHome.class);
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test02_getHomeInterfaceClass() {
+        try {
+            final Class clazz = ejbMetaData.getHomeInterfaceClass();
+            assertNotNull("The Home Interface class is null", clazz);
+            assertEquals(clazz, BasicBmpHome.class);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test03_getPrimaryKeyClass(){
-        try{
-        Class clazz = ejbMetaData.getPrimaryKeyClass();
-        assertNotNull( "The EJBMetaData is null", clazz );
-        assertEquals(clazz , Integer.class);
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test03_getPrimaryKeyClass() {
+        try {
+            final Class clazz = ejbMetaData.getPrimaryKeyClass();
+            assertNotNull("The EJBMetaData is null", clazz);
+            assertEquals(clazz, Integer.class);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test04_getRemoteInterfaceClass(){
-        try{
-        Class clazz = ejbMetaData.getRemoteInterfaceClass();
-        assertNotNull( "The Remote Interface class is null", clazz );
-        assertEquals(clazz , BasicBmpObject.class);
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test04_getRemoteInterfaceClass() {
+        try {
+            final Class clazz = ejbMetaData.getRemoteInterfaceClass();
+            assertNotNull("The Remote Interface class is null", clazz);
+            assertEquals(clazz, BasicBmpObject.class);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test05_isSession(){
-        try{
-        assertTrue( "EJBMetaData says this is a session bean", !ejbMetaData.isSession() );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test05_isSession() {
+        try {
+            assertTrue("EJBMetaData says this is a session bean", !ejbMetaData.isSession());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test06_isStatelessSession(){
-        try{
-        assertTrue( "EJBMetaData says this is a stateless session bean", !ejbMetaData.isStatelessSession() );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test06_isStatelessSession() {
+        try {
+            assertTrue("EJBMetaData says this is a stateless session bean", !ejbMetaData.isStatelessSession());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
     //

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbObjectTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbObjectTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbObjectTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpEjbObjectTests.java Tue Jul 15 21:55:09 2014
@@ -21,26 +21,25 @@ import javax.ejb.ObjectNotFoundException
 
 /**
  * [4] Should be run as the fourth test suite of the BasicBmpTestClients
- *
  */
-public class BmpEjbObjectTests extends BasicBmpTestClient{
+public class BmpEjbObjectTests extends BasicBmpTestClient {
 
-    public BmpEjbObjectTests(){
+    public BmpEjbObjectTests() {
         super("EJBObject.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbObject = ejbHome.createObject("Third Bean");
     }
 
     protected void tearDown() throws Exception {
-        if(ejbObject!=null){// set to null by test05_remove() method
-            try{
-            ejbObject.remove();
-            }catch(Exception e){
+        if (ejbObject != null) {// set to null by test05_remove() method
+            try {
+                ejbObject.remove();
+            } catch (final Exception e) {
                 throw e;
             }
         }
@@ -50,44 +49,44 @@ public class BmpEjbObjectTests extends B
     //===============================
     // Test ejb object methods
     //
-    public void test01_getHandle(){
-        try{
+    public void test01_getHandle() {
+        try {
             ejbHandle = ejbObject.getHandle();
-            assertNotNull( "The Handle is null", ejbHandle );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+            assertNotNull("The Handle is null", ejbHandle);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test02_getPrimaryKey(){
-        try{
-            ejbPrimaryKey = (Integer)ejbObject.getPrimaryKey();
-            assertNotNull( "The primary key is null", ejbPrimaryKey );
-        } catch (Exception e){
+    public void test02_getPrimaryKey() {
+        try {
+            ejbPrimaryKey = (Integer) ejbObject.getPrimaryKey();
+            assertNotNull("The primary key is null", ejbPrimaryKey);
+        } catch (final Exception e) {
             e.printStackTrace();
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test03_isIdentical(){
-        try{
-            assertTrue("The EJBObjects are not identical", ejbObject.isIdentical(ejbObject) );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test03_isIdentical() {
+        try {
+            assertTrue("The EJBObjects are not identical", ejbObject.isIdentical(ejbObject));
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test04_getEjbHome(){
-        try{
-            EJBHome home = ejbObject.getEJBHome();
-            assertNotNull( "The EJBHome is null", home );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test04_getEjbHome() {
+        try {
+            final EJBHome home = ejbObject.getEJBHome();
+            assertNotNull("The EJBHome is null", home);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test05_remove(){
-        try{
+    public void test05_remove() {
+        try {
             // remove the ejb
             ejbObject.remove();
 
@@ -95,18 +94,18 @@ public class BmpEjbObjectTests extends B
             try {
                 ejbHome.findByPrimaryKey((Integer) ejbPrimaryKey);
                 fail("Entity was not actually removed");
-            } catch (ObjectNotFoundException e) {
+            } catch (final ObjectNotFoundException e) {
             }
 
             // verify the proxy is dead
-            try{
+            try {
                 ejbObject.businessMethod("Should throw an exception");
-                assertTrue( "Calling business method after removing the EJBObject does not throw an exception", false );
-            } catch (Exception e){
+                assertTrue("Calling business method after removing the EJBObject does not throw an exception", false);
+            } catch (final Exception e) {
             }
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
-        } finally{
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
+        } finally {
             ejbObject = null;
         }
     }

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHandleTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHandleTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHandleTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHandleTests.java Tue Jul 15 21:55:09 2014
@@ -20,24 +20,23 @@ import javax.ejb.EJBObject;
 
 /**
  * [7] Should be run as the seventh test suite of the BasicBmpTestClients
- *
  */
-public class BmpHandleTests extends BasicBmpTestClient{
+public class BmpHandleTests extends BasicBmpTestClient {
 
-    public BmpHandleTests(){
+    public BmpHandleTests() {
         super("Handle.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbObject = ejbHome.createObject("Fifth Bean");
         ejbHandle = ejbObject.getHandle();
     }
 
-    protected void tearDown() throws Exception{
-        if(ejbObject !=null)
+    protected void tearDown() throws Exception {
+        if (ejbObject != null)
             ejbObject.remove();
         super.tearDown();
     }
@@ -45,15 +44,15 @@ public class BmpHandleTests extends Basi
     //=================================
     // Test handle methods
     //
-    public void test01_getEJBObject(){
+    public void test01_getEJBObject() {
 
-        try{
-            EJBObject object = ejbHandle.getEJBObject();
-            assertNotNull( "The EJBObject is null", object );
+        try {
+            final EJBObject object = ejbHandle.getEJBObject();
+            assertNotNull("The EJBObject is null", object);
             // Wait until isIdentical is working.
             //assertTrue("EJBObjects are not identical", object.isIdentical(ejbObject));
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
@@ -62,20 +61,20 @@ public class BmpHandleTests extends Basi
      * is more a test on the handle then on the remove method
      * itself.
      */
-    public void Xtest02_EJBHome_remove(){
-        try{
+    public void Xtest02_EJBHome_remove() {
+        try {
             ejbHome.remove(ejbHandle);
-            try{
+            try {
                 ejbObject.businessMethod("Should throw an exception");
-                assertTrue( "Calling business method after removing the EJBObject does not throw an exception", false );
-            } catch (Exception e){
-                assertTrue( true );
+                assertTrue("Calling business method after removing the EJBObject does not throw an exception", false);
+            } catch (final Exception e) {
+                assertTrue(true);
                 return;
             }
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
-        } finally{
-            ejbObject  = null;
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
+        } finally {
+            ejbObject = null;
         }
     }
     //

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeHandleTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeHandleTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeHandleTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeHandleTests.java Tue Jul 15 21:55:09 2014
@@ -20,30 +20,29 @@ import javax.ejb.EJBHome;
 
 /**
  * [6] Should be run as the sixth test suite of the BasicBmpTestClients
- * 
  */
-public class BmpHomeHandleTests extends BasicBmpTestClient{
+public class BmpHomeHandleTests extends BasicBmpTestClient {
 
-    public BmpHomeHandleTests(){
+    public BmpHomeHandleTests() {
         super("HomeHandle.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbHomeHandle = ejbHome.getHomeHandle();
     }
-        
+
     //=================================
     // Test home handle methods
     //
-    public void test01_getEJBHome(){
-        try{
-            EJBHome home = ejbHomeHandle.getEJBHome();
-            assertNotNull( "The EJBHome is null", home );
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test01_getEJBHome() {
+        try {
+            final EJBHome home = ejbHomeHandle.getEJBHome();
+            assertNotNull("The EJBHome is null", home);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
     //

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeIntfcTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeIntfcTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeIntfcTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpHomeIntfcTests.java Tue Jul 15 21:55:09 2014
@@ -18,7 +18,6 @@ package org.apache.openejb.test.entity.b
 
 /**
  * [2] Should be run as the second test suite of the BasicBmpTestClients
- * 
  */
 public class BmpHomeIntfcTests extends BasicBmpTestClient {
 
@@ -28,7 +27,7 @@ public class BmpHomeIntfcTests extends B
 
     protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
         ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
     }
 
@@ -39,7 +38,7 @@ public class BmpHomeIntfcTests extends B
         try {
             ejbObject = ejbHome.createObject("First Bean");
             assertNotNull("The EJBObject is null", ejbObject);
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
@@ -49,13 +48,13 @@ public class BmpHomeIntfcTests extends B
             ejbPrimaryKey = ejbObject.getPrimaryKey();
             ejbObject = ejbHome.findByPrimaryKey((Integer) ejbPrimaryKey);
             assertNotNull("The EJBObject is null", ejbObject);
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test03_findByLastName() {
-        Integer[] keys = new Integer[3];
+        final Integer[] keys = new Integer[3];
         try {
             ejbObject = ejbHome.createObject("David Blevins");
             keys[0] = (Integer) ejbObject.getPrimaryKey();
@@ -65,41 +64,41 @@ public class BmpHomeIntfcTests extends B
 
             ejbObject = ejbHome.createObject("Claude Blevins");
             keys[2] = (Integer) ejbObject.getPrimaryKey();
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received exception while preparing the test: " + e.getClass() + " : " + e.getMessage());
         }
 
         try {
-            java.util.Collection objects = ejbHome.findByLastName("Blevins");
+            final java.util.Collection objects = ejbHome.findByLastName("Blevins");
             assertNotNull("The Collection is null", objects);
             assertEquals("The Collection is not the right size.", keys.length, objects.size());
-            Object[] objs = objects.toArray();
+            final Object[] objs = objects.toArray();
             for (int i = 0; i < objs.length; i++) {
                 ejbObject = (BasicBmpObject) javax.rmi.PortableRemoteObject.narrow(objs[i], BasicBmpObject.class);
                 // This could be problematic, it assumes the order of the collection.
                 assertEquals("The primary keys are not equal.", keys[i], ejbObject.getPrimaryKey());
             }
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test04_findEmptyEnumeration() {
         try {
-            java.util.Enumeration emptyEnumeration = ejbHome.findEmptyEnumeration();
+            final java.util.Enumeration emptyEnumeration = ejbHome.findEmptyEnumeration();
             assertNotNull("The enumeration is null", emptyEnumeration);
             assertFalse("The enumeration is not empty", emptyEnumeration.hasMoreElements());
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test05_homeMethod() {
         try {
-            int expected = 8;
-            int actual = ejbHome.sum(5, 3);
+            final int expected = 8;
+            final int actual = ejbHome.sum(5, 3);
             assertEquals("home method returned wrong result", expected, actual);
-        } catch (Exception e) {
+        } catch (final Exception e) {
             fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiEncTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiEncTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiEncTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiEncTests.java Tue Jul 15 21:55:09 2014
@@ -20,231 +20,230 @@ import org.apache.openejb.test.TestFailu
 
 /**
  * [4] Should be run as the fourth test suite of the EncBmpTestClients
- * 
  */
-public class BmpJndiEncTests extends BmpTestClient{
+public class BmpJndiEncTests extends BmpTestClient {
 
-    protected EncBmpHome   ejbHome;
+    protected EncBmpHome ejbHome;
     protected EncBmpObject ejbObject;
-    
-    public BmpJndiEncTests(){
+
+    public BmpJndiEncTests() {
         super("JNDI_ENC.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/EncBean");
-        ejbHome = (EncBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, EncBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/EncBean");
+        ejbHome = (EncBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, EncBmpHome.class);
         ejbObject = ejbHome.create("Enc Bean");
     }
-    
+
     protected void tearDown() throws Exception {
         try {
             //ejbObject.remove();
-        } catch (Exception e){
+        } catch (final Exception e) {
             throw e;
         } finally {
             super.tearDown();
         }
     }
-    
+
     public void test01_lookupStringEntry() {
-        try{
+        try {
             ejbObject.lookupStringEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
-    public void test02_lookupDoubleEntry() { 
-        try{
+
+    public void test02_lookupDoubleEntry() {
+        try {
             ejbObject.lookupDoubleEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
-    public void test03_lookupLongEntry() {   
-        try{
+
+    public void test03_lookupLongEntry() {
+        try {
             ejbObject.lookupLongEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
-    public void test04_lookupFloatEntry() {  
-        try{
+
+    public void test04_lookupFloatEntry() {
+        try {
             ejbObject.lookupFloatEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test05_lookupIntegerEntry() {
-        try{
+        try {
             ejbObject.lookupIntegerEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
-    public void test06_lookupShortEntry() {  
-        try{
+
+    public void test06_lookupShortEntry() {
+        try {
             ejbObject.lookupShortEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test07_lookupBooleanEntry() {
-        try{
+        try {
             ejbObject.lookupBooleanEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
-    public void test08_lookupByteEntry() {   
-        try{
+
+    public void test08_lookupByteEntry() {
+        try {
             ejbObject.lookupByteEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test09_lookupCharacterEntry() {
-        try{
+        try {
             ejbObject.lookupCharacterEntry();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test10_lookupEntityBean() {
-        try{
+        try {
             ejbObject.lookupEntityBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test11_lookupStatefulBean() {
-        try{
+        try {
             ejbObject.lookupStatefulBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test12_lookupStatelessBean() {
-        try{
+        try {
             ejbObject.lookupStatelessBean();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test13_lookupResource() {
-        try{
+        try {
             ejbObject.lookupResource();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test14_lookupPersistenceUnit() {
-        try{
+        try {
             ejbObject.lookupPersistenceUnit();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test15_lookupPersistenceContext() {
-        try{
+        try {
             ejbObject.lookupPersistenceContext();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
-    
+
     public void test19_lookupStatelessBusinessLocal() {
-        try{
+        try {
             ejbObject.lookupStatelessBusinessLocal();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test20_lookupStatelessBusinessRemote() {
-        try{
+        try {
             ejbObject.lookupStatelessBusinessRemote();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test21_lookupStatefulBusinessLocal() {
-        try{
+        try {
             ejbObject.lookupStatefulBusinessLocal();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test22_lookupStatefulBusinessRemote() {
-        try{
+        try {
             ejbObject.lookupStatefulBusinessRemote();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
     public void test23_lookupJMSConnectionFactory() {
-        try{
+        try {
             ejbObject.lookupJMSConnectionFactory();
-        } catch (TestFailureException e){
+        } catch (final TestFailureException e) {
             throw e.error;
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 }

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpJndiTests.java Tue Jul 15 21:55:09 2014
@@ -19,21 +19,20 @@ package org.apache.openejb.test.entity.b
 
 /**
  * [1] Should be run as the first test suite of the BasicBmpTestClients
- * 
  */
-public class BmpJndiTests extends BasicBmpTestClient{
+public class BmpJndiTests extends BasicBmpTestClient {
 
-    public BmpJndiTests(){
+    public BmpJndiTests() {
         super("JNDI.");
     }
 
-    public void test01_Jndi_lookupHome(){
-        try{
-            Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-            ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+    public void test01_Jndi_lookupHome() {
+        try {
+            final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+            ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
             assertNotNull("The EJBHome is null", ejbHome);
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpLocalTestSuite.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpLocalTestSuite.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpLocalTestSuite.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpLocalTestSuite.java Tue Jul 15 21:55:09 2014
@@ -49,10 +49,10 @@ public class BmpLocalTestSuite extends o
      * This method is called before a test is executed.
      */
     protected void setUp() throws Exception {
-        Properties props = TestManager.getServer().getContextEnvironment();
+        final Properties props = TestManager.getServer().getContextEnvironment();
         //props.put(Context.SECURITY_PRINCIPAL, "ENTITY_TEST_CLIENT");
         //props.put(Context.SECURITY_CREDENTIALS, "ENTITY_TEST_CLIENT");
-        InitialContext initialContext = new InitialContext(props);
+        final InitialContext initialContext = new InitialContext(props);
 
         /*[2] Create database table */
         TestManager.getDatabase().createEntityTable();

Modified: tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpRemoteIntfcTests.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpRemoteIntfcTests.java?rev=1610862&r1=1610861&r2=1610862&view=diff
==============================================================================
--- tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpRemoteIntfcTests.java (original)
+++ tomee/tomee/trunk/itests/openejb-itests-client/src/main/java/org/apache/openejb/test/entity/bmp/BmpRemoteIntfcTests.java Tue Jul 15 21:55:09 2014
@@ -19,92 +19,92 @@ package org.apache.openejb.test.entity.b
 
 /**
  * [5] Should be run as the fifth test suite of the BasicBmpTestClients
- * 
  */
-public class BmpRemoteIntfcTests extends BasicBmpTestClient{
+public class BmpRemoteIntfcTests extends BasicBmpTestClient {
 
-    public BmpRemoteIntfcTests(){
+    public BmpRemoteIntfcTests() {
         super("RemoteIntfc.");
     }
 
-    protected void setUp() throws Exception{
+    protected void setUp() throws Exception {
         super.setUp();
-        Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
-        ejbHome = (BasicBmpHome)javax.rmi.PortableRemoteObject.narrow( obj, BasicBmpHome.class);
+        final Object obj = initialContext.lookup("client/tests/entity/bmp/BasicBmpHome");
+        ejbHome = (BasicBmpHome) javax.rmi.PortableRemoteObject.narrow(obj, BasicBmpHome.class);
         ejbObject = ejbHome.createObject("Forth Bean");
     }
-    
+
     //=================================
     // Test remote interface methods
     //
-    public void test01_businessMethod(){
-        try{
-        String expected = "Success";
-        String actual = ejbObject.businessMethod("sseccuS");
-        assertEquals(expected, actual);
-        } catch (Exception e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test01_businessMethod() {
+        try {
+            final String expected = "Success";
+            final String actual = ejbObject.businessMethod("sseccuS");
+            assertEquals(expected, actual);
+        } catch (final Exception e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
+
     /**
      * Throw an application exception and make sure the exception
      * reaches the bean nicely.
      */
-    public void test02_throwApplicationException(){
-        try{
+    public void test02_throwApplicationException() {
+        try {
             ejbObject.throwApplicationException();
-        } catch (org.apache.openejb.test.ApplicationException e){
+        } catch (final org.apache.openejb.test.ApplicationException e) {
             //Good.  This is the correct behaviour
             return;
-        } catch (Throwable e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Throwable e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
         fail("An ApplicationException should have been thrown.");
     }
-    
+
     /**
-     * After an application exception we should still be able to 
+     * After an application exception we should still be able to
      * use our bean
      */
-    public void test03_invokeAfterApplicationException(){
-        try{
-        String expected = "Success";
-        String actual   = ejbObject.businessMethod("sseccuS");
-        assertEquals(expected, actual);
-        } catch (Throwable e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+    public void test03_invokeAfterApplicationException() {
+        try {
+            final String expected = "Success";
+            final String actual = ejbObject.businessMethod("sseccuS");
+            assertEquals(expected, actual);
+        } catch (final Throwable e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
 
-    public void test04_throwSystemException(){
-        try{
+    public void test04_throwSystemException() {
+        try {
             ejbObject.throwSystemException_NullPointer();
-        } catch (java.rmi.RemoteException e){
+        } catch (final java.rmi.RemoteException e) {
             //Good, so far.
-            Throwable n = e.detail;
-            assertNotNull("Nested exception should not be is null", n );
-            assertTrue("Nested exception should be an instance of NullPointerException, but exception is "+n.getClass().getName(), (n instanceof NullPointerException));
+            final Throwable n = e.detail;
+            assertNotNull("Nested exception should not be is null", n);
+            assertTrue("Nested exception should be an instance of NullPointerException, but exception is " + n.getClass().getName(), (n instanceof NullPointerException));
             return;
-        } catch (Throwable e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Throwable e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
         fail("A NullPointerException should have been thrown.");
     }
-    
+
     /**
      * After a system exception the intance should be garbage collected
      * and the remote reference should be invalidated.
-     * 
+     * <p/>
      * The Remote Server fails this one, that should be fixed.
      */
-    public void BUG_test05_invokeAfterSystemException(){
-        try{
-        ejbObject.businessMethod("This refernce is invalid");
-        fail("A java.rmi.NoSuchObjectException should have been thrown.");
-        } catch (java.rmi.NoSuchObjectException e){
+    public void BUG_test05_invokeAfterSystemException() {
+        try {
+            ejbObject.businessMethod("This refernce is invalid");
+            fail("A java.rmi.NoSuchObjectException should have been thrown.");
+        } catch (final java.rmi.NoSuchObjectException e) {
             // Good.
-        } catch (Throwable e){
-            fail("Received Exception "+e.getClass()+ " : "+e.getMessage());
+        } catch (final Throwable e) {
+            fail("Received Exception " + e.getClass() + " : " + e.getMessage());
         }
     }
     //