You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2016/10/05 21:09:27 UTC
[GitHub] incubator-quickstep pull request #108: Remove unnecessary code from FastSepa...
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/108
Remove unnecessary code from FastSeparateChainingHashTable::resize()
- In resize, all the values are moved from original hash table are
copied to the new hash table using memcpy().
- Removed the for loop where values are constructed using 'new' operator, as
all the values are trivially constructible in the specialized
aggregation hash table implementation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep fix-fasthash-resize
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #108
----
commit 3e8f6c9a36ea3e0e5526d7baaf4279c34fdfcd85
Author: Harshad Deshmukh <hb...@apache.org>
Date: 2016-10-05T21:05:05Z
Remove unnecessary code from resize()
- In resize, all the values are moved from original hash table are
copied to the new hash table using memcpy().
- Removed the for loop where values are constructed using 'new' operator, as
all the values are trivially constructible in the specialized
aggregation hash table implementation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #108: Remove unnecessary code from FastSeparateCha...
Posted by pateljm <gi...@git.apache.org>.
Github user pateljm commented on the issue:
https://github.com/apache/incubator-quickstep/pull/108
LGTM. Merging since Travis was run before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #108: Remove unnecessary code from FastSepa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---