You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "choo121600 (via GitHub)" <gi...@apache.org> on 2025/11/19 11:09:58 UTC

[I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

choo121600 opened a new issue, #58487:
URL: https://github.com/apache/airflow/issues/58487

   ### Apache Airflow version
   
   3.1.3
   
   ### If "Other Airflow 2/3 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   <img width="2168" height="1397" alt="Image" src="https://github.com/user-attachments/assets/c7b9a12e-373e-4518-882a-29d211732ac6" />
   
   When running the --add-missing option, the missing translation keys are added correctly, 
   but the JSON file is reordered in an unexpected way that does not follow the original sorting order.
   I remember we had a similar issue before, which was addressed in #53692
   
   ### What you think should happen instead?
   
   _No response_
   
   ### How to reproduce
   
   The file should be sorted consistently and correctly
   
   ### Operating System
   
   os x
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3644760376

   we can close this issue ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3649493867

   Yep. I forgot to close it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553564819

   Basically - to summarize it -  convert check_translation_completness into a regular breeze command, and run prek run eslint as part of it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3552121719

   I think it would be helpful to establish clear rules for translation key ordering, as well as consistent pre-commit and ESLint guidelines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553557307

   @sunank200 -> I assigned you :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553554728

   Yep. We discussed it yesterday with Jens: https://github.com/apache/airflow/pull/58460#issuecomment-3549957695 and we proposed a plan how this shoudl be done and @sunank200 wrote he would love to work on it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553559663

   Cool ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553642339

   @sunank200 
   Let me leave a note about an issue Iā€™m aware of.
   
   The following part of the code is currently causing the problem. Previously, the sorting logic used a lower-cased comparison, but the current behavior no longer applies lower() when sorting:
   
   https://github.com/apache/airflow/blob/5f7b74a3385357e03a1c345bd67106b273660f8c/dev/i18n/check_translations_completeness.py#L608
   
   Additionally, one question came to mind:
   If we can assume that the English keys are always properly sorted, then instead of re-sorting the translation keys independently, it might be better to align the translation key order to match the English source.
   
   This would prevent unnecessary reordering and keep the structure consistent across locales.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 closed issue #58487: Translation keys are incorrectly sorted after running `--add-missing`
URL: https://github.com/apache/airflow/issues/58487


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Translation keys are incorrectly sorted after running `--add-missing` [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on issue #58487:
URL: https://github.com/apache/airflow/issues/58487#issuecomment-3553637912

   > Basically - to summarize it - convert check_translation_completness into a regular breeze command, and run prek run eslint as part of it :)
   
   Wow, this looks great šŸ™Œ


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org