You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org> on 2011/12/20 18:08:30 UTC
[jira] [Commented] (JCR-3185) refactor consistency checks in
BundleDBPersistenceManager into a standalone class that could be re-used
for other PMs
[ https://issues.apache.org/jira/browse/JCR-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173312#comment-13173312 ]
Jukka Zitting commented on JCR-3185:
------------------------------------
+1 Looks straightforward enough, and moving the code outside the PM implementations make sense.
I wonder if it might be a good idea to change getAllNodeIds() to return a Collection (or a Set) instead of an Iterable so we wouldn't need the extra getNumberOfBundles() call. AFAIUI all PM implementations in any case implement getAllNodeIds() with an in-memory list so the memory impact shouldn't be a problem (and if it is, the getAllNodeIds() signature already contains the maxCount option for dealing with that issue). And implementing getAllNodeIds() with an actual backend iterator opens up problems about when and how the resources used by the iterator can and should be released.
PS. There's an svn:executable property in the patch that probably shouldn't be there.
> refactor consistency checks in BundleDBPersistenceManager into a standalone class that could be re-used for other PMs
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: JCR-3185
> URL: https://issues.apache.org/jira/browse/JCR-3185
> Project: Jackrabbit Content Repository
> Issue Type: Task
> Components: jackrabbit-core
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3185.diff
>
>
> see subject
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira