You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/25 23:15:21 UTC
[GitHub] [lucene-solr] janhoy opened a new pull request #1288: SOLR-14281:
Make sharedLib configurable through SysProp
janhoy opened a new pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288
...and allow multiple comma separated paths
See https://issues.apache.org/jira/browse/SOLR-14281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288:
SOLR-14281: Make sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384499124
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -607,19 +609,31 @@ public PackageStoreAPI getPackageStoreAPI() {
public void load() {
log.debug("Loading cores into CoreContainer [instanceDir={}]", loader.getInstancePath());
+ // Always add $SOLR_HOME/lib to the shared resource loader
+ Set<String> libDirs = new HashSet<>();
+ libDirs.add("lib");
+
+ if (!StringUtils.isBlank(cfg.getSharedLibDirectory())) {
+ List<String> sharedLibs = Arrays.asList(cfg.getSharedLibDirectory().split("\\s*,\\s*"));
Review comment:
I'm almost certain we've got a utility that does this so that you don't have to define your regexp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy merged pull request #1288: SOLR-14281: Make
sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288:
SOLR-14281: Make sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384498162
##########
File path: solr/CHANGES.txt
##########
@@ -110,6 +110,9 @@ Improvements
* SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in production (janhoy)
+* SOLR-14281: Make sharedLib configurable through SysProp and allow multiple comma separated paths.
Review comment:
SysProp should by "sys-prop" or system property. The way you capitalized it makes it seem like some class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1288:
SOLR-14281: Make sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384806562
##########
File path: solr/CHANGES.txt
##########
@@ -110,6 +110,9 @@ Improvements
* SOLR-14114: Add WARN to Solr log that embedded ZK is not supported in production (janhoy)
+* SOLR-14281: Make sharedLib configurable through SysProp and allow multiple comma separated paths.
Review comment:
Re-phrased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1288:
SOLR-14281: Make sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384499506
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -607,19 +609,31 @@ public PackageStoreAPI getPackageStoreAPI() {
public void load() {
log.debug("Loading cores into CoreContainer [instanceDir={}]", loader.getInstancePath());
+ // Always add $SOLR_HOME/lib to the shared resource loader
+ Set<String> libDirs = new HashSet<>();
Review comment:
Use LinkedHashSet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1288:
SOLR-14281: Make sharedLib configurable through SysProp
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1288: SOLR-14281: Make sharedLib configurable through SysProp
URL: https://github.com/apache/lucene-solr/pull/1288#discussion_r384807112
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -607,19 +609,31 @@ public PackageStoreAPI getPackageStoreAPI() {
public void load() {
log.debug("Loading cores into CoreContainer [instanceDir={}]", loader.getInstancePath());
+ // Always add $SOLR_HOME/lib to the shared resource loader
+ Set<String> libDirs = new HashSet<>();
+ libDirs.add("lib");
+
+ if (!StringUtils.isBlank(cfg.getSharedLibDirectory())) {
+ List<String> sharedLibs = Arrays.asList(cfg.getSharedLibDirectory().split("\\s*,\\s*"));
Review comment:
I tried `StrUtils.splitSmart()` but we don't need the smartness of not splitting inside quotes etc, and it does not trim whitespace around comma. So I'll keep this unless you know about a better split-util somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org