You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/20 20:47:24 UTC
Review Request 26950: Slider View: App summary should not scroll
horizontally
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26950/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
Bugs: AMBARI-7874
https://issues.apache.org/jira/browse/AMBARI-7874
Repository: ambari
Description
-------
When a slider app summary page is being viewed, a user is able to scroll the page horizontally - which then chops off the left part of the view.
If possible we should not scroll horizontally.
Diffs
-----
contrib/views/slider/src/main/resources/ui/app/styles/app.less de2e8fe
contrib/views/slider/src/main/resources/ui/app/templates/slider_app/summary.hbs dfa3d4f
Diff: https://reviews.apache.org/r/26950/diff/
Testing
-------
4520 tests complete (6 seconds)
60 tests pending
adding tests skipped as it's small style changes
Thanks,
Andriy Babiichuk
Re: Review Request 26950: Slider View: App summary should not scroll
horizontally
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26950/#review57526
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 20, 2014, 6:47 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26950/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2014, 6:47 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-7874
> https://issues.apache.org/jira/browse/AMBARI-7874
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When a slider app summary page is being viewed, a user is able to scroll the page horizontally - which then chops off the left part of the view.
> If possible we should not scroll horizontally.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/styles/app.less de2e8fe
> contrib/views/slider/src/main/resources/ui/app/templates/slider_app/summary.hbs dfa3d4f
>
> Diff: https://reviews.apache.org/r/26950/diff/
>
>
> Testing
> -------
>
> 4520 tests complete (6 seconds)
> 60 tests pending
> adding tests skipped as it's small style changes
>
>
> Thanks,
>
> Andriy Babiichuk
>
>