You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/05 22:45:35 UTC
[GitHub] [incubator-superset] betodealmeida opened a new issue #11587: SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button
betodealmeida opened a new issue #11587:
URL: https://github.com/apache/incubator-superset/issues/11587
In SQL Lab, if the text area is empty the "RUN" button is disabled, but the user can still press the key shortcut to run the empty query. This results in an error.
### Expected results
Shortcut keys should be ignored.
### Actual results
Query runs.
#### Screenshots

#### How to reproduce the bug
1. Go to SQL Lab
2. Delete everything in the text area (including `SELECT ...`)
3. Press CTRL+R
4. See error
### Environment
(please complete the following information):
- superset version: master
- python version: 3.8
- node.js version: 1.14.11
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [X] I have reproduced the issue with at least the latest released version of superset.
- [X] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas closed issue #11587: SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #11587:
URL: https://github.com/apache/incubator-superset/issues/11587
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11587: SQL Lab: CTRL+R and CTRL+ENTER bypass disabled RUN button
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11587:
URL: https://github.com/apache/incubator-superset/issues/11587#issuecomment-722688687
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org