[GitHub] [accumulo] dlmarion commented on a change in pull request #2490: Changes to ExternalCompaction ITs

[GitBox <gi...@apache.org>]

dlmarion commented on a change in pull request #2490:
URL: https://github.com/apache/accumulo/pull/2490#discussion_r806155025



##########
File path: test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionProgressIT.java
##########
@@ -75,15 +81,16 @@ public void configureMiniCluster(MiniAccumuloConfigImpl cfg, Configuration coreS
 
   @Test
   public void testProgress() throws Exception {
-    MiniAccumuloClusterImpl.ProcessInfo c1 = null, coord = null;
     String table1 = this.getUniqueNames(1)[0];
     try (AccumuloClient client =
         Accumulo.newClient().from(getCluster().getClientProperties()).build()) {
-      ExternalCompactionTestUtils.createTable(client, table1, "cs1");
-      ExternalCompactionTestUtils.writeData(client, table1, ROWS);
-      c1 = ((MiniAccumuloClusterImpl) getCluster()).exec(Compactor.class, "-q", "DCQ1");
-      coord = ExternalCompactionTestUtils.startCoordinator(((MiniAccumuloClusterImpl) getCluster()),
-          CompactionCoordinator.class, getCluster().getServerContext());
+      createTable(client, table1, "cs1");
+      writeData(client, table1, ROWS);
+
+      ((MiniAccumuloClusterImpl) cluster).getClusterControl().startCompactors(Compactor.class, 1,

Review comment:
       Added startCoordinator and startCompactors to ClusterControl interface in [851c2c3] to remove casting. Throw UnsupportedOperationException for these methods in StandaloneClusterControl as they are not implemented yet.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org