You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sebastian Toader <st...@hortonworks.com> on 2015/12/09 22:33:21 UTC
Review Request 41150: Storm configuration wrong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
Bugs: AMBARI-14302
https://issues.apache.org/jira/browse/AMBARI-14302
Repository: ambari
Description
-------
BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort.
In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf
Diff: https://reviews.apache.org/r/41150/diff/
Testing
-------
Unit tests in progress....
Manual testing in progress...
Thanks,
Sebastian Toader
Re: Review Request 41150: Storm configuration wrong
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/#review109734
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Dec. 9, 2015, 9:33 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41150/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 9:33 p.m.)
>
>
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14302
> https://issues.apache.org/jira/browse/AMBARI-14302
>
>
> Repository: ambari
>
>
> Description
> -------
>
> BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort.
>
> In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf
>
> Diff: https://reviews.apache.org/r/41150/diff/
>
>
> Testing
> -------
>
> Unit tests in progress....
>
> Manual testing in progress...
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 41150: Storm configuration wrong
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/#review109609
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Dec. 9, 2015, 9:33 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41150/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 9:33 p.m.)
>
>
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14302
> https://issues.apache.org/jira/browse/AMBARI-14302
>
>
> Repository: ambari
>
>
> Description
> -------
>
> BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort.
>
> In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf
>
> Diff: https://reviews.apache.org/r/41150/diff/
>
>
> Testing
> -------
>
> Unit tests in progress....
>
> Manual testing in progress...
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 41150: Storm configuration wrong
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/#review109605
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Dec. 9, 2015, 9:33 p.m., Sebastian Toader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41150/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 9:33 p.m.)
>
>
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14302
> https://issues.apache.org/jira/browse/AMBARI-14302
>
>
> Repository: ambari
>
>
> Description
> -------
>
> BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort.
>
> In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf
>
> Diff: https://reviews.apache.org/r/41150/diff/
>
>
> Testing
> -------
>
> Unit tests in progress....
>
> Manual testing in progress...
>
>
> Thanks,
>
> Sebastian Toader
>
>
Re: Review Request 41150: Storm configuration wrong
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41150/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 1:41 p.m.)
Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
Bugs: AMBARI-14302
https://issues.apache.org/jira/browse/AMBARI-14302
Repository: ambari
Description
-------
BlueprintConfigurationProcessor.YamlMultiValuePropertyDecorator was not prepared to handle properties that were already in correct format. It has been changed to recognize if the input property value is already in the correct format in order to not distort.
In cases where a cluster is created with a Blueprint that was previously exported the storm yaml properties are already in correct format thus no need to add surrounding [] to the property value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java b3e99b1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java b4b50cf
Diff: https://reviews.apache.org/r/41150/diff/
Testing (updated)
-------
Unit tests:
Results :
Tests run: 3606, Failures: 0, Errors: 0, Skipped: 28
Manual testing:
1. Tested with one node cluster re-created using an exported blueprint
2. Tested with 3 node cluster re-created using an exported blueprint
Thanks,
Sebastian Toader