You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/13 15:16:29 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1529: [KYUUBI #1525][FLINK] Implement GetCatalogs operation and do the further initialization

pan3793 commented on pull request #1529:
URL: https://github.com/apache/incubator-kyuubi/pull/1529#issuecomment-992581199


   The implementation overall LGTM, few concerns
   1. Is Legacy Planner necessary? It's not recommended and removed in a recent version, removing the support will reduce the maintenance effort in the Kyuubi side.
   2. I think we are implementing a Flink SQL Gateway,  IIRC, `StreamExecutionEnvironment` is designed as a low-level programming API, TableAPI should satisfy our requirement, why should introduce `StreamExecutionEnvironment`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org