[GitHub] [guacamole-client] madmath03 commented on a change in pull request #470: GUACAMOLE-124: Add full-screen action

[GitBox <gi...@apache.org>]

madmath03 commented on a change in pull request #470: GUACAMOLE-124: Add full-screen action
URL: https://github.com/apache/guacamole-client/pull/470#discussion_r386148294
 
 

 ##########
 File path: guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js
 ##########
 @@ -134,6 +135,64 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
                 return authenticationService.isAnonymous();
             };
 
+            /**
+             * All available actions for the current user.
+             */
+            $scope.actions = [ ];
+
+            // Initialize fullscreen functions
+            var docElem = document.documentElement;
+            var requestFullscreen = docElem.mozRequestFullScreen
+                || docElem.webkitRequestFullscreen
+                || docElem.msRequestFullscreen;
+            var exitFullscreen = document.mozCancelFullScreen
+                || document.webkitExitFullscreen
+                || document.msExitFullscreen;
+            if (!!requestFullscreen && !!exitFullscreen) {
+                // Bind browser-specific fullscreen functions
+                if (!docElem.requestFullscreen) {
+                    docElem.requestFullscreen = (requestFullscreen).bind(docElem);
+                }
+                if (!document.exitFullscreen) {
+                    document.exitFullscreen = (exitFullscreen).bind(document);
+                }
+    
+                /**
+                 * Toggles fullscreen for the Guacamole page.
+                 */
+                $scope.fullscreen = function fullscreen() {
+                    var fullscreenElem = !!(document.fullscreenElement 
+                        || document.msFullscreenElement
+                        || document.mozFullScreenElement
+                        || document.webkitFullscreenElement);
+    
+                    if (!fullscreenElem) {
+                        document.documentElement.requestFullscreen();
+                    }
+                    else {
+                        document.exitFullscreen();
+                    }
+                };
+    
+                /**
+                 * Action which requests fullscreen for the Guacamole page.
+                 */
+                var FULLSCREEN_ACTION = {
+                    name      : 'USER_MENU.ACTION_FULLSCREEN',
+                    className : 'fullscreen',
+                    callback  : $scope.fullscreen
+                };
+    
+                /**
+                 * Add fullscreen action for the current user.
+                 */
+                $scope.actions = $scope.actions.concat( FULLSCREEN_ACTION );
 
 Review comment:
   You're right. I should have added the standard version in `requestFullscreen` and `exitFullscreen`.
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services