You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "William R. Speirs (JIRA)" <ji...@apache.org> on 2012/08/07 23:37:10 UTC
[jira] [Created] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
William R. Speirs created HTTPCORE-307:
------------------------------------------
Summary: Make HttpAsyncService.getRequestHandler() protected
Key: HTTPCORE-307
URL: https://issues.apache.org/jira/browse/HTTPCORE-307
Project: HttpComponents HttpCore
Issue Type: Improvement
Components: HttpCore NIO
Affects Versions: 4.2.1
Reporter: William R. Speirs
Fix For: 4.3-alpha1
Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430642#comment-13430642 ]
William R. Speirs commented on HTTPCORE-307:
--------------------------------------------
Attached simple diff to change HttpAsyncService.getRequestHandler() to protected.
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Updated] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
William R. Speirs updated HTTPCORE-307:
---------------------------------------
Attachment: HTTPCORE-307.diff
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431274#comment-13431274 ]
Oleg Kalnichevski commented on HTTPCORE-307:
--------------------------------------------
Gary
There is actually no reason. In the early days of HttpCore I and Roland used to make keep of the inner structures and internal methods protected per default just in case someone might want to access or override them. This turned out to be a rather bad idea. These days I tend to keep things private or package visible per default until someone asks to make them protected.
Oleg
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431089#comment-13431089 ]
Gary D. Gregory commented on HTTPCORE-307:
------------------------------------------
The only downside to applying this patch is that it makes binary compatibility a little harder.
Can anyone comment on whether this is appropriate as far as as 'breaking' encapsulation? After all, it must be private for a reason.
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Resolved] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCORE-307.
----------------------------------------
Resolution: Not A Problem
Fix Version/s: (was: 4.3-alpha1)
I guess this one is no longer relevant.
Oleg
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] [Commented] (HTTPCORE-307) Make
HttpAsyncService.getRequestHandler() protected
Posted by "William R. Speirs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430645#comment-13430645 ]
William R. Speirs commented on HTTPCORE-307:
--------------------------------------------
As a work-around, someone could simply implement an HttpAsyncRequestHandlerResolver which matches on /* and then does additional routing based upon the HttpRequest.
> Make HttpAsyncService.getRequestHandler() protected
> ---------------------------------------------------
>
> Key: HTTPCORE-307
> URL: https://issues.apache.org/jira/browse/HTTPCORE-307
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.2.1
> Reporter: William R. Speirs
> Fix For: 4.3-alpha1
>
> Attachments: HTTPCORE-307.diff
>
>
> Currently HttpAsyncService.getRequestHandler() is marked as private which makes implementing something like Virtual Host support very difficult because the only way resolve a Handler is by URI. Making HttpAsyncService.getRequestHandler() protected would allow someone to extend HttpAsyncService and resolve a handler based upon the whole HttpRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org