You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/21 16:24:12 UTC

[GitHub] [ignite] rpuch commented on pull request #9503: IGNITE-15416 False warnings from default Checkpoint and Collision SPIs

rpuch commented on pull request #9503:
URL: https://github.com/apache/ignite/pull/9503#issuecomment-948776733


   Hello @kukushal 
   
   Thank you for your review and your suggestions. I've made the following changes:
   
   1. Converted the test you mentioned from an integration test to a unit test
   2. Switched from using log4j `Appender` to a mock to assert that the message of interest is logged using an expected log level.
   
   Could you please take a look at the PR again?
   
   The suite including the related test is rerun successfully: https://ci.ignite.apache.org/viewLog.html?buildId=6233444&buildTypeId=IgniteTests24Java8_ComputeGrid


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org