You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/06/04 21:06:29 UTC

[GitHub] [trafficcontrol] ocket8888 opened a new pull request #3657: Improved TP UI tests performance and fixed up the README

ocket8888 opened a new pull request #3657: Improved TP UI tests performance and fixed up the README
URL: https://github.com/apache/trafficcontrol/pull/3657
 
 
   ## What does this PR (Pull Request) do?
   - [ ] This PR is not related to any Issue
   Previously, each view change was accompanied by issuing a fresh request to the running TP instance.
   This means that every time a view was loaded, both Angular and Protractor need to run through their
   bootstrap and setup processes. This behavior has been replaced by the more proper navigation using
   AngularJS's router for 'in-page navigation'
   
   ## Which Traffic Control components are affected by this PR?
   
   - Documentation
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   Run the TP UI tests. If you don't know how to do that, that's perfect, because I also changed the README that describes how to run them. So also make sure they aren't too vague for you to run the tests.
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services