[GitHub] [airflow] nsuthar-lumiq commented on a diff in pull request #26206: Glue job continuously Cloudwatch logging in Airflow

[GitBox <gi...@apache.org>]

nsuthar-lumiq commented on code in PR #26206:
URL: https://github.com/apache/airflow/pull/26206#discussion_r965626742


##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -144,40 +146,39 @@ def get_job_state(self, job_name: str, run_id: str) -> str:
         job_run = glue_client.get_job_run(JobName=job_name, RunId=run_id, PredecessorsIncluded=True)
         return job_run['JobRun']['JobRunState']
 
+
     def print_job_logs(
         self,
         job_name: str,
         run_id: str,
+        log_client,

Review Comment:
   Do you mean passing log_client as a parameter will create a compatibility issue? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org