You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/04 16:20:00 UTC
[jira] [Commented] (SCB-367) Fix LICENSE and NOTICE file issue of
Service Center
[ https://issues.apache.org/jira/browse/SCB-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385218#comment-16385218 ]
ASF GitHub Bot commented on SCB-367:
------------------------------------
yangbor opened a new pull request #295: [SCB-367] Fix LICENSE and NOTICE issue
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/295
Separated LICENSE and NOTICE for binary and source releases.
Removed bits not suitable for NOTICE and added missing licensing information.
Also modified release scripts to use the binary NOTICE and LICENSE files.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Fix LICENSE and NOTICE file issue of Service Center
> ---------------------------------------------------
>
> Key: SCB-367
> URL: https://issues.apache.org/jira/browse/SCB-367
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Service-Center
> Affects Versions: service-center-1.0.0-m1
> Reporter: Willem Jiang
> Priority: Major
>
> As the [vote mail |https://lists.apache.org/thread.html/c8dbb301c5d635226214248e5821f5e8abab9427f58bab714afaa65f@%3Cgeneral.incubator.apache.org%3E]from Justin had point out, we need to fix the LICENSE and NOTICE issues
> * LICENSE should include the bundled third part project's LICENSE information
> * We should keep NOTICE simple don't put every details into it.
> * We need to provide different LICENSE and NOTICE file for the src and binary release kits.
> You can find more information about LICENSE and NOTICE [here|http://www.apache.org/dev/licensing-howto.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)