You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/08 01:35:18 UTC
[GitHub] [arrow-datafusion] jonmmease opened a new pull request, #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
jonmmease opened a new pull request, #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848
# Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/4846 for `var`, `var_pop`, `stddev`, and `stddev_pop`.
The actual `retract_batch` function was already implemented, but it looks like the `create_sliding_accumulator` implementations weren't added previously so it wasn't possible to use these aggregate functions in window expressions that use custom frames.
# Are these changes tested?
The test added in effc4728912684f63b2e4ce837ae1b1816796480 will fail until https://github.com/apache/arrow-datafusion/pull/4847 is merged and this branch is updated.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
`var`, `var_pop`, `stddev`, and `stddev_pop` will now work in window expressions that use custom frames rather than raising an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jonmmease commented on pull request #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
Posted by GitBox <gi...@apache.org>.
jonmmease commented on PR #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848#issuecomment-1376059087
Can this be merged? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jonmmease commented on pull request #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
Posted by GitBox <gi...@apache.org>.
jonmmease commented on PR #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848#issuecomment-1374842793
Ok, this is ready to go now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848#issuecomment-1376798281
Nice -- thank you @jonmmease and @ozankabak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848#issuecomment-1376801429
Benchmark runs are scheduled for baseline = 13fb42efec4b5ab7f9aa251f1705fdcf89057d23 and contender = 292eb954fc0bad3a1febc597233ba26cb60bda3e. 292eb954fc0bad3a1febc597233ba26cb60bda3e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/597674ce0c554b6c87821768e1a80ede...7fa5429ba5fc4323b33a306c3ea156f3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5d9e1bc44e204f3a982e1786fd6bcc0b...337f5b7a8b8944bda0f0425ea232e627/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/89f47298cf844a66bbb6ea7f935e19d3...2e4be53365ae4c42a27f8f84b96d17bf/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/89d3d1c9c5af48c39a55df97f307a4c4...bad9c40adbb34927a3668ca46355549e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4848: Support using var/var_pop/stddev/stddev_pop in window expressions with custom frames
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4848:
URL: https://github.com/apache/arrow-datafusion/pull/4848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org