You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Vadim Gritsenko <va...@reverycodes.com> on 2004/08/10 17:49:08 UTC
StaticBucketMap, Re: DO NOT REPLY [Bug 30148] - Internal server
Error
bugzilla@apache.org wrote:
> <http://issues.apache.org/bugzilla/show_bug.cgi?id=30148>.
>
> ------- Additional Comments From lars.rottmann@vodafone.com 2004-08-10 11:01 -------
> The bug was fixed in 2.1.4. Carsten kindly replaced any reference to the
> StaticBucketMap with a synchronized HashMap (not nice, but it works). This was
> done in the Excalibur ComponentManager package. Commons-Collections still has
> the non-threadsafe StaticBucketMap in it.
I took a looong look at the current version of StaticBucketMap [1] but
fail to see how it is not thread safe... Can anybody give a guess, what
can go wrong in this code?
Vadim
[1]
http://cvs.apache.org/viewcvs.cgi/jakarta-commons/collections/src/java/org/apache/commons/collections/map/StaticBucketMap.java?annotate=1.11
RE: StaticBucketMap,
Re: DO NOT REPLY [Bug 30148] - Internal serverError
Posted by Antonio Gallardo <ag...@agssa.net>.
Carsten Ziegeler dijo:
>
>
>> -----Original Message-----
>> From: Vadim Gritsenko [mailto:vadim@reverycodes.com]
>> Sent: Tuesday, August 10, 2004 5:49 PM
>> To: dev@cocoon.apache.org
>> Subject: StaticBucketMap, Re: DO NOT REPLY [Bug 30148] -
>> Internal serverError
>>
>> bugzilla@apache.org wrote:
>> > <http://issues.apache.org/bugzilla/show_bug.cgi?id=30148>.
>> >
>> > ------- Additional Comments From lars.rottmann@vodafone.com
>> > 2004-08-10 11:01 ------- The bug was fixed in 2.1.4. Carsten kindly
>> > replaced any reference to the StaticBucketMap with a synchronized
>> > HashMap (not nice, but it works). This was done in the Excalibur
>> > ComponentManager package. Commons-Collections still has the
>> non-threadsafe StaticBucketMap in it.
>>
>> I took a looong look at the current version of
>> StaticBucketMap [1] but fail to see how it is not thread
>> safe... Can anybody give a guess, what can go wrong in this code?
>>
> I can't :( I looked as well through this code and didn't find anything.
> But there must be something, as not only Lars but several others had
> problems with this map under heavy load. Making the map synchronized
> fixed the problem in all cases.
Can you please report it to the commons-collectiosn guys?
Best Regards,
Antonio Gallardo
>
> Carsten
>
RE: StaticBucketMap, Re: DO NOT REPLY [Bug 30148] - Internal serverError
Posted by Carsten Ziegeler <cz...@s-und-n.de>.
> -----Original Message-----
> From: Vadim Gritsenko [mailto:vadim@reverycodes.com]
> Sent: Tuesday, August 10, 2004 5:49 PM
> To: dev@cocoon.apache.org
> Subject: StaticBucketMap, Re: DO NOT REPLY [Bug 30148] -
> Internal serverError
>
> bugzilla@apache.org wrote:
> > <http://issues.apache.org/bugzilla/show_bug.cgi?id=30148>.
> >
> > ------- Additional Comments From lars.rottmann@vodafone.com
> > 2004-08-10 11:01 ------- The bug was fixed in 2.1.4. Carsten kindly
> > replaced any reference to the StaticBucketMap with a synchronized
> > HashMap (not nice, but it works). This was done in the Excalibur
> > ComponentManager package. Commons-Collections still has the
> non-threadsafe StaticBucketMap in it.
>
> I took a looong look at the current version of
> StaticBucketMap [1] but fail to see how it is not thread
> safe... Can anybody give a guess, what can go wrong in this code?
>
I can't :( I looked as well through this code and didn't find anything.
But there must be something, as not only Lars but several others had
problems with this map under heavy load. Making the map synchronized
fixed the problem in all cases.
Carsten