You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/25 09:28:02 UTC

[GitHub] [flink] AHeise commented on pull request #13237: [FLINK-17159] Harden ElasticsearchSinkITCase

AHeise commented on pull request #13237:
URL: https://github.com/apache/flink/pull/13237#issuecomment-679914192


   > That's a good question. AFAIK, we don't have many (or any) tests currently that use ASSUME. If we used it in this test here we could get into the situation that we change sth and the cluster never comes up and we then basically "disable" this test and don't notice problems anymore. WDYT?
   
   I agree. We also have quite a few disabled tests since ages and noone really looks at skipped tests, I'd assume. 
   So let's go with assert and we can still convert it into assume if it turns out to be an issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org