You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/03 22:19:47 UTC

[GitHub] [incubator-nuttx] AlanRosenthal commented on a change in pull request #5375: Generate $(SCRIPTOUT) during the build phase

AlanRosenthal commented on a change in pull request #5375:
URL: https://github.com/apache/incubator-nuttx/pull/5375#discussion_r799016094



##########
File path: boards/xtensa/esp32s2/esp32s2-saola-1/src/Make.defs
##########
@@ -44,14 +44,10 @@ endif
 SCRIPTIN = $(SCRIPTDIR)$(DELIM)esp32s2.template.ld
 SCRIPTOUT = $(SCRIPTDIR)$(DELIM)esp32s2_out.ld
 
-.PHONY = context distclean
-
 $(SCRIPTOUT): $(SCRIPTIN) $(CONFIGFILE)

Review comment:
       So it's a bit confusing how it currently is defined. Definitely open to suggestions to make it more straightforward.
   Currently the rules for `SCRIPTOUT` is defined in `arch/arm/<arch-name>/board/board/Make.defs` aka `$(BOARD_DIR)/src/Make.defs`
   `arch/<arch-name>/src/board/Makefile` includes `board/Make.defs`. Right now the way I'm generating `$(SCRIPTOUT)` is by essentially calling `make -C board $(SCRIPTOUT)`, because that Makefile knows how to create the file.
   
   I could modify `arch/<arch-name>/src/Makefile` to `include /board/board/Make.defs` and then add the dependency to `nuttx$(EXEEXT)`
   
   @xiaoxiang781216 is that what you had in mind or did you have a different idea?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org