You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Emmanuel Bourg <e....@cross-systems.com> on 2004/01/12 19:10:53 UTC

[configuration] unit test clean up

Hi, here is a patch removing useless constructors, suite() and main() 
methods from the JUnit tests. It does a bit of code reformatting as 
well. Any committer around to apply it please ? :)

Emmanuel Bourg


Re: [configuration] unit test clean up

Posted by "Craig R. McClanahan" <cr...@apache.org>.
Quoting Emmanuel Bourg <e....@cross-systems.com>:

> Craig your mail program is haunted, it replies on its own with no text 
> added ;)
> 

I wish I could claim that as an excuse :-) but it was actually a case of fumble
fingers.  I'm a moderator on COMMONS-DEV and when I glanced at this message
thought it was one that needed to be moderated through.  The way a moderator
does that is replies to the moderation message -- of course, on a *real* list
message that just sends the reploy to the list and makes me look foolish :-).

Craig

> 
> Craig R. McClanahan wrote:
> 
> > Quoting Emmanuel Bourg <e....@cross-systems.com>:
> > 
> > 
> >>Hi, here is a patch removing useless constructors, suite() and main() 
> >>methods from the JUnit tests. It does a bit of code reformatting as 
> >>well. Any committer around to apply it please ? :)
> >>
> >>Emmanuel Bourg
> >>
> >>
> > 
> > 
> > 
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > 
> > 
> > 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [configuration] unit test clean up

Posted by Emmanuel Bourg <e....@cross-systems.com>.
Craig your mail program is haunted, it replies on its own with no text 
added ;)


Craig R. McClanahan wrote:

> Quoting Emmanuel Bourg <e....@cross-systems.com>:
> 
> 
>>Hi, here is a patch removing useless constructors, suite() and main() 
>>methods from the JUnit tests. It does a bit of code reformatting as 
>>well. Any committer around to apply it please ? :)
>>
>>Emmanuel Bourg
>>
>>
> 
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [configuration] unit test clean up

Posted by "Craig R. McClanahan" <cr...@apache.org>.
Quoting Emmanuel Bourg <e....@cross-systems.com>:

> Hi, here is a patch removing useless constructors, suite() and main() 
> methods from the JUnit tests. It does a bit of code reformatting as 
> well. Any committer around to apply it please ? :)
> 
> Emmanuel Bourg
> 
> 




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


RE: [configuration] unit test clean up

Posted by Eric Pugh <ep...@upstate.com>.
Re: [configuration] unit test clean upI have applied the patch.  Thanks..
It definitly cuts down on all the boiler plate that seems to creep into
JUnit tests!
  -----Original Message-----
  From: Emmanuel Bourg [mailto:e.bourg@cross-systems.com]
  Sent: Tuesday, January 13, 2004 12:49 PM
  To: Jakarta Commons Developers List
  Subject: Re: [configuration] unit test clean up


  Patch update, I have split the very long testRetrieve in
  TestBaseConfiguration into smaller testGetBoolean, testGetLong...
  methods. I have also reinforced the test on Configuration.getList.

  Emmanuel Bourg



  Emmanuel Bourg wrote:

  > Hi, here is a patch removing useless constructors, suite() and main()
  > methods from the JUnit tests. It does a bit of code reformatting as
  > well. Any committer around to apply it please ? :)
  >
  > Emmanuel Bourg



Re: [configuration] unit test clean up

Posted by Emmanuel Bourg <e....@cross-systems.com>.
Patch update, I have split the very long testRetrieve in 
TestBaseConfiguration into smaller testGetBoolean, testGetLong... 
methods. I have also reinforced the test on Configuration.getList.

Emmanuel Bourg


Emmanuel Bourg wrote:

> Hi, here is a patch removing useless constructors, suite() and main() 
> methods from the JUnit tests. It does a bit of code reformatting as 
> well. Any committer around to apply it please ? :)
> 
> Emmanuel Bourg