You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "silver-ymz (via GitHub)" <gi...@apache.org> on 2023/06/09 16:21:19 UTC
[GitHub] [incubator-opendal] silver-ymz commented on pull request #2431: fix(services/sftp): support relative path for root config
silver-ymz commented on PR #2431:
URL: https://github.com/apache/incubator-opendal/pull/2431#issuecomment-1584838375
Update:
- change default root to remote server setting.
- add a new test job for it
The default root path in `sftp` can be set by both `ChrootDirectory` and `sftp-server` argument. And `ChrootDirectory` will change the apparent root directory, which means the program can't access files and commands outside that environmental directory tree. If `ChrootDirectory` is set to `/home/foo`, the previous implementation will create `/home/foo/home/foo`. I think it's an inappropriate behavior. So, in current implementation, it will do nothing if the user don't set root config.
About the github action test, because `atmoz/sftp` limits users to write the root directory, I have to modify `/etc/ssh/sshd_config` to change its initial entry directory.
Could you make a review about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org