[GitHub] [dubbo-go] ZLBer commented on a diff in pull request #1945: feat: support xds certificate

[GitBox <gi...@apache.org>]

ZLBer commented on code in PR #1945:
URL: https://github.com/apache/dubbo-go/pull/1945#discussion_r933988192


##########
xds/credentials/certgenerate/generate_cert.go:
##########
@@ -242,12 +242,12 @@ func GenCertFromCSR(csr *x509.CertificateRequest, signingCert *x509.Certificate,
 //	signerCertFile: cert file name
 //	signerPrivFile: private key file name
 func LoadSignerCredsFromFiles(signerCertFile string, signerPrivFile string) (*x509.Certificate, crypto.PrivateKey, error) {
-	signerCertBytes, err := os.ReadFile(signerCertFile)
+	signerCertBytes, err := ioutil.ReadFile(signerCertFile)

Review Comment:
   这个是因为golint检查报错我才改成ioutil包的, 因为dubbo-go用的go 1.15版本没有os.ReadFile这个函数。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org