You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Xiangdong Huang <sa...@gmail.com> on 2019/02/01 15:17:32 UTC
please do not submit PR from your forked repo (for all initial committers)
Hi,
I remember some mentor said that "do not submit PR from your forked repo"
if you are an initial committer.
If you create a new branch, then Apache Jenkins can cover it. So, we can
guarantee the master can pass the Apache Jenkins test after merging the PR.
However, if you create a new branch in your repo and submit a PR, we have
no idea to guarantee the master is ok after mergence. (e.g., PR #36 @Yi Xu)
I think we may need to require all PRs that come from forked Repo target to
the dev branch, rather than the master branch. Then, the steps are:
1. Merge the PR into the dev branch;
2. run Apache's Jenkins for the dev branch;
3. If Step 2 is ok, then merge the master with the dev branch;
In this way, we can avoid to roll back the master branch.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Re: please do not submit PR from your forked repo (for all initial committers)
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
I rewrite the configuration file of travic-CI, Now IoTDB CI on travis
supports:
* osx-oraclejdk8
* osx-oraclejdk11
* osx-openjdk8
* osx-openjdk11
* linux-oraclejdk8 (ubuntu)
* linux-oraclejdk11 (ubuntu)
* linux-openjdk8 (ubuntu)
* linux-openjdk11 (ubuntu)
* Windows-oraclejdk8
* Windows-oraclejdk11
See #PR40 (https://github.com/apache/incubator-iotdb/pull/40).
Once the PR is merged, the CI will work.
The only thing we need to concern is the CI on travis takes too long time
(maybe ~1 hour) :(. Travis has a feature called `cache`, which can
accelerate the process, but it is a little difficult to set it. Hope we can
enable the cache function to accelerate the CI.
And, there are some problem of openJDK on Win (so I disable it now), I need
a Win environment to test and fix it. But now it is Spring Festival holiday
in China now and I have no the environment on hand...
By the way, there are some ITs failed on some OS platforms. Look forward to
fix them ASAP.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Re: please do not submit PR from your forked repo (for all initial committers)
Posted by 吴晟 Sheng Wu <wu...@foxmail.com>.
+1 from me. In SkyWalking. I am the only one using the branch not from fork repo, also travis ci and Jenkins job covers the test job for pr.
Sheng Wu
Apache SkyWalking, ShardingSphere, Zipkin
From Wu Sheng 's phone.
------------------ Original ------------------
From: Willem Jiang <wi...@gmail.com>
Date: Mon,Feb 4,2019 2:16 AM
To: dev <de...@iotdb.apache.org>
Subject: Re: please do not submit PR from your forked repo (for all initial committers)
Sending the PR from forked branch is good way, it's much safe way for
the newbee to go.
Not sure if the Jenkins can send a comments for the PR result.
In ServiceComb Pack [1], we just leverage travis to run the CI, once
the test passed, travis send a message to github, we can easily tell
the PR is good or bad.
[1]https://github.com/apache/servicecomb-pack/pull/403
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Feb 1, 2019 at 11:17 PM Xiangdong Huang <sa...@gmail.com> wrote:
>
> Hi,
>
> I remember some mentor said that "do not submit PR from your forked repo"
> if you are an initial committer.
>
> If you create a new branch, then Apache Jenkins can cover it. So, we can
> guarantee the master can pass the Apache Jenkins test after merging the PR.
>
> However, if you create a new branch in your repo and submit a PR, we have
> no idea to guarantee the master is ok after mergence. (e.g., PR #36 @Yi Xu)
>
> I think we may need to require all PRs that come from forked Repo target to
> the dev branch, rather than the master branch. Then, the steps are:
>
> 1. Merge the PR into the dev branch;
> 2. run Apache's Jenkins for the dev branch;
> 3. If Step 2 is ok, then merge the master with the dev branch;
> In this way, we can avoid to roll back the master branch.
>
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
Re: please do not submit PR from your forked repo (for all initial committers)
Posted by Willem Jiang <wi...@gmail.com>.
Sending the PR from forked branch is good way, it's much safe way for
the newbee to go.
Not sure if the Jenkins can send a comments for the PR result.
In ServiceComb Pack [1], we just leverage travis to run the CI, once
the test passed, travis send a message to github, we can easily tell
the PR is good or bad.
[1]https://github.com/apache/servicecomb-pack/pull/403
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Feb 1, 2019 at 11:17 PM Xiangdong Huang <sa...@gmail.com> wrote:
>
> Hi,
>
> I remember some mentor said that "do not submit PR from your forked repo"
> if you are an initial committer.
>
> If you create a new branch, then Apache Jenkins can cover it. So, we can
> guarantee the master can pass the Apache Jenkins test after merging the PR.
>
> However, if you create a new branch in your repo and submit a PR, we have
> no idea to guarantee the master is ok after mergence. (e.g., PR #36 @Yi Xu)
>
> I think we may need to require all PRs that come from forked Repo target to
> the dev branch, rather than the master branch. Then, the steps are:
>
> 1. Merge the PR into the dev branch;
> 2. run Apache's Jenkins for the dev branch;
> 3. If Step 2 is ok, then merge the master with the dev branch;
> In this way, we can avoid to roll back the master branch.
>
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院