[GitHub] [superset] graceguo-supercat commented on a change in pull request #16992: feat: [Migrate filter_box to filter component] add transition mode

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r726510318



##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
   centered?: boolean;
   footer?: React.ReactNode;
   wrapProps?: object;
+  maskStyle?: object;

Review comment:
       add this props from AntD. I want to show the top Superset menu bar out of modal mask:
   <img width="1411" alt="Screen Shot 2021-10-11 at 12 06 23 PM" src="https://user-images.githubusercontent.com/27990562/136843526-7ebbd472-9c1f-4c4e-b490-99596dda0b30.png">
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org