You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/08/11 23:55:15 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42451: [SPARK-44775][PYTHON][DOCS] Add missing version information in DataFrame APIs

HyukjinKwon commented on code in PR #42451:
URL: https://github.com/apache/spark/pull/42451#discussion_r1291893263


##########
python/pyspark/sql/dataframe.py:
##########
@@ -4066,6 +4078,9 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> "
 
          .. versionadded:: 3.5.0
 
+        .. versionchanged:: 3.5.0

Review Comment:
   Yeah it's a bit odd but we have used this way to describe the support of Spark Connect. Let's keep it consistent for now, and fix all later separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org