[GitHub] [lucene] mayya-sharipova commented on pull request #926: VectorSimilarityFunction reverse removal

[GitBox <gi...@apache.org>]

mayya-sharipova commented on PR #926:
URL: https://github.com/apache/lucene/pull/926#issuecomment-1141499461

   > The tie-breaking by Lucene docId (smaller id wins) doesn't actually work right now(for the regular similarities) and not for Euclidean after my changes.
   
   > The node ID and score encoding in the HEAP was broken for such edge cases in my opinion for the majority of similarity functions.
   Euclidean tests were green because of the reverse!
   
   @alessandrobenedetti Thank for your investigations. I understand now why tests were failing (e.g. advanceShallow), and the reason is that because they were originally not completely correct (e.g. using COSINE similarity instead of euclidean in this test would make the returned doc IDs different).
   
    > I have reverted this and proposed a possible solution.
   
   The proposed solution looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org