[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #131: GEODE-8348: Add support for customizable purpose tag.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #131:
URL: https://github.com/apache/geode-benchmarks/pull/131#discussion_r455391423



##########
File path: infrastructure/scripts/aws/launch_cluster.sh
##########
@@ -76,6 +86,10 @@ if [ -z "${CI}" ]; then
   CI=0
 fi
 
+if [ -z "${PURPOSE}" ]; then

Review comment:
       Bashmagic:
   `PURPOSE=${PURPOSE:-"geode-benchmarks"}`

##########
File path: infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
##########
@@ -397,11 +397,17 @@ private static Image getNewestImage() {
     DateTimeFormatter inputFormatter =
         DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", Locale.ENGLISH);
 
+    String purpose = System.getProperty("PURPOSE");

Review comment:
       Properties also supports a default value. So you can drop the empty check and do this.
   
   `String purpose = System.getProperty("PURPOSE", "geode-benchmarks")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org