You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2005/07/16 13:24:53 UTC
DO NOT REPLY [Bug 35763] New: -
[collections] UnboundedFifoBuffer deserialization is broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35763>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35763
Summary: [collections] UnboundedFifoBuffer deserialization is
broken
Product: Commons
Version: 3.1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Collections
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: scolebourne@joda.org
The patch should be:
private void readObject(ObjectInputStream in) throws IOException,
ClassNotFoundException {
in.defaultReadObject();
int size = in.readInt();
- buffer = new Object[size];
+ buffer = new Object[size + 1];
for (int i = 0; i < size; i++) {
buffer[i] = in.readObject();
}
head = 0;
tail = size;
}
Setting tail = size - 1; just caused another bug (ie you couldn't get the last
element in the buffer). This is because tail is supposed to point to the next
unused cell in the buffer array. By creating the buffer to be size + 1, tail
will be set to a valid cell within buffer that is empty (but the cell before it
has an element in it), and the class works properly.
Thomas Knych, Jordan Krey & Citigroup Analytics Dev team
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org