You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2020/01/23 08:22:38 UTC
[GitHub] [spark-website] EnricoMi opened a new pull request #253: Annotating
link to Spark PRs page with
EnricoMi opened a new pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253
The link can not be clicked otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] EnricoMi commented on a change in pull request
#253: Annotating link to Spark PRs page with
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on a change in pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253#discussion_r370013998
##########
File path: contributing.md
##########
@@ -48,7 +48,8 @@ Anyone can view and comment on active changes here.
Reviewing others' changes is a good way to learn how the change process works and gain exposure
to activity in various parts of the code. You can help by reviewing the changes and asking
questions or pointing out issues -- as simple as typos or small issues of style.
-See also https://spark-prs.appspot.com/ for a convenient way to view and filter open PRs.
+See also <a href="https://spark-prs.appspot.com/">https://spark-prs.appspot.com/</a> for a
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HyukjinKwon commented on a change in pull request
#253: Annotating link to Spark PRs page with
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253#discussion_r370012102
##########
File path: contributing.md
##########
@@ -48,7 +48,8 @@ Anyone can view and comment on active changes here.
Reviewing others' changes is a good way to learn how the change process works and gain exposure
to activity in various parts of the code. You can help by reviewing the changes and asking
questions or pointing out issues -- as simple as typos or small issues of style.
-See also https://spark-prs.appspot.com/ for a convenient way to view and filter open PRs.
+See also <a href="https://spark-prs.appspot.com/">https://spark-prs.appspot.com/</a> for a
Review comment:
Yeah, it happens due to different versions. You can manually exclude unrelated changes except this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HyukjinKwon commented on a change in pull request
#253: Annotating link to Spark PRs page with
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253#discussion_r370007200
##########
File path: contributing.md
##########
@@ -48,7 +48,8 @@ Anyone can view and comment on active changes here.
Reviewing others' changes is a good way to learn how the change process works and gain exposure
to activity in various parts of the code. You can help by reviewing the changes and asking
questions or pointing out issues -- as simple as typos or small issues of style.
-See also https://spark-prs.appspot.com/ for a convenient way to view and filter open PRs.
+See also <a href="https://spark-prs.appspot.com/">https://spark-prs.appspot.com/</a> for a
Review comment:
@EnricoMi, can you generate HTML too accordingly? See https://github.com/apache/spark-website#generating-the-website-html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen closed pull request #253: Annotating link to
Spark PRs page with
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a change in pull request #253:
Annotating link to Spark PRs page with
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253#discussion_r370172877
##########
File path: contributing.md
##########
@@ -48,7 +48,8 @@ Anyone can view and comment on active changes here.
Reviewing others' changes is a good way to learn how the change process works and gain exposure
to activity in various parts of the code. You can help by reviewing the changes and asking
questions or pointing out issues -- as simple as typos or small issues of style.
-See also https://spark-prs.appspot.com/ for a convenient way to view and filter open PRs.
+See also <a href="https://spark-prs.appspot.com/">https://spark-prs.appspot.com/</a> for a
Review comment:
It can use markdown link syntax too like `[..](...)` but it doesn't matter. Seems fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] EnricoMi commented on a change in pull request
#253: Annotating link to Spark PRs page with
Posted by GitBox <gi...@apache.org>.
EnricoMi commented on a change in pull request #253: Annotating link to Spark PRs page with <a>
URL: https://github.com/apache/spark-website/pull/253#discussion_r370008130
##########
File path: contributing.md
##########
@@ -48,7 +48,8 @@ Anyone can view and comment on active changes here.
Reviewing others' changes is a good way to learn how the change process works and gain exposure
to activity in various parts of the code. You can help by reviewing the changes and asking
questions or pointing out issues -- as simple as typos or small issues of style.
-See also https://spark-prs.appspot.com/ for a convenient way to view and filter open PRs.
+See also <a href="https://spark-prs.appspot.com/">https://spark-prs.appspot.com/</a> for a
Review comment:
I did, I run jekyll 4.0.0 and it generated a lot of unrelated changes. I will try again with <4.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org