You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kim P. (JIRA)" <ji...@apache.org> on 2009/03/31 11:59:50 UTC
[jira] Created: (HIVE-381) HiveResultSet next() always returned
true due to bad string comparison.
HiveResultSet next() always returned true due to bad string comparison.
-----------------------------------------------------------------------
Key: HIVE-381
URL: https://issues.apache.org/jira/browse/HIVE-381
Project: Hadoop Hive
Issue Type: Bug
Reporter: Kim P.
Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) HiveResultSet next() always returned
true due to bad string comparison.
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Affects Version/s: 0.4.0
0.3.0
0.2.0
> HiveResultSet next() always returned true due to bad string comparison.
> -----------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Attachment: HiveResultSet.java
Attached HiveResultSet.java (SVN revision 760370) contained described fixes
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Attachments: HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-381:
--------------------------------
Fix Version/s: 0.4.0
Affects Version/s: (was: 0.4.0)
(was: 0.6.0)
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Drivers
> Affects Versions: 0.3.0
> Reporter: Kim P.
> Assignee: Kim P.
> Fix For: 0.4.0
>
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Attachment: HIVE-381.patch
Fixes for next() to return false when reaching the last record in the Resultset
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694643#action_12694643 ]
Namit Jain commented on HIVE-381:
---------------------------------
The patch does not contain the unit test
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-381:
----------------------------
Comment: was deleted
(was: +1
looks good - I will run the tests and commit if it succeeds.
)
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Attachment: HIVE-381.2.patch
Modified TestJdbcDriver.java to also check for no more data rows
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694282#action_12694282 ]
Namit Jain commented on HIVE-381:
---------------------------------
Can you upload a patch instead of the file:
svn diff > <patchname>
and then upload the <patchname> and submit patch.
Also, can you add a test for this case ?
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Attachments: HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Status: Patch Available (was: Open)
Fixes for next() to return false when reaching the last record in the Resultset
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694852#action_12694852 ]
Namit Jain commented on HIVE-381:
---------------------------------
Kim, after looking at the code again, I had some questions:
In the test (without your patch), the while loop should have never exited, and eventually some random timeout happened.
I am not sure how is it working without your patch ?
I should not have accepted in the first place - I will delete the above comment
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim P. updated HIVE-381:
------------------------
Summary: [JDBC component] HiveResultSet next() always returned true due to bad string comparison (was: HiveResultSet next() always returned true due to bad string comparison.)
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo reassigned HIVE-381:
----------------------------------
Assignee: Kim P.
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Kim P. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694317#action_12694317 ]
Kim P. commented on HIVE-381:
-----------------------------
Sure + will modify the current unit test to check for this condition.
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Attachments: HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694796#action_12694796 ]
Namit Jain commented on HIVE-381:
---------------------------------
+1
looks good - I will run the tests and commit if it succeeds.
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-381:
--------------------------------
Component/s: Drivers
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Drivers
> Affects Versions: 0.3.0, 0.4.0, 0.6.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-381:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed. Thanks Kim
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-381) [JDBC component] HiveResultSet next()
always returned true due to bad string comparison
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696636#action_12696636 ]
Namit Jain commented on HIVE-381:
---------------------------------
Investigated the test in more detail with Raghu and Ashish. The current test is working due to some java idiosyncrasy.
Your changes look good.
+1
> [JDBC component] HiveResultSet next() always returned true due to bad string comparison
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-381
> URL: https://issues.apache.org/jira/browse/HIVE-381
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.2.0, 0.3.0, 0.4.0
> Reporter: Kim P.
> Assignee: Kim P.
> Attachments: HIVE-381.2.patch, HIVE-381.patch, HiveResultSet.java
>
>
> Method next() is comparing String using "!=" operator resulted in "true" being returned all the time. Can be fix by using String equals() operation to check.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.