You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Guillaume Boué (JIRA)" <ji...@apache.org> on 2016/10/08 18:45:20 UTC

[jira] [Commented] (MSHARED-595) In DefaultProjectInstaller, the path to the local repository should be retrieved from the RepositoryManager

    [ https://issues.apache.org/jira/browse/MSHARED-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558507#comment-15558507 ] 

Guillaume Boué commented on MSHARED-595:
----------------------------------------

Fixed in [r1763929|http://svn.apache.org/viewvc?view=revision&revision=1763929].

> In DefaultProjectInstaller, the path to the local repository should be retrieved from the RepositoryManager
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: MSHARED-595
>                 URL: https://issues.apache.org/jira/browse/MSHARED-595
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-artifact-transfer
>            Reporter: Guillaume Boué
>             Fix For: maven-artifact-transfer-3.0.0
>
>
> The current code retrieving the path of a given artifact from the local repository is currently:
> {noformat}
> private File getLocalRepoFile( ProjectBuildingRequest buildingRequest, ArtifactRepository artifactRepository,
>                                    Artifact artifact )
> {
>     String path = repositoryManager.getPathForLocalArtifact( buildingRequest, artifact );
>     return new File( artifactRepository.getBasedir(), path );
> }
> {noformat}
> It correctly gets the path of the given artifact inside the current local repository from the {{RepositoryManager}}, but the base directory of the local repository is obtained from the given {{ArtifactRepository}}. If they are not in sync, this won't correctly return the full path to the artifact.
> This needs to be modified to get the local repository base directory also from the {{RepositoryManager}}, by invoking {{repositoryManager.getLocalRepositoryBasedir}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)