You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/06 19:16:13 UTC
[jira] [Commented] (STORM-750) Set Serialization Id for Config
[ https://issues.apache.org/jira/browse/STORM-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481445#comment-14481445 ]
ASF GitHub Bot commented on STORM-750:
--------------------------------------
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/507
STORM-750: Set Config serialVersionUID
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-750
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit 3a5d3a7892086f4a99f0b35f16a5207eb0522d5d
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-04-06T17:13:35Z
STORM-750: Set Config Serialization
----
> Set Serialization Id for Config
> -------------------------------
>
> Key: STORM-750
> URL: https://issues.apache.org/jira/browse/STORM-750
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Labels: newbie
>
> We have had several customers write bolts or spouts that don't do the right thing and end up caching the Config somewhere in the bolt or spout instance. Sometimes in odd ways through anonymous inner classes that should have been static but were not and debugging them because of the bad java serialization errors is really hard.
> Instead of beating on them to clean up these references every time we upgrade a cluster, or force them to keep their client perfectly in sync with the server, I propose that we set the serialization id for Config. Config stores no state except in the parent class so it really should not matter if we add more methods to it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)