You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/12 01:05:03 UTC
[GitHub] [netbeans] mbien opened a new pull request, #4105: migrate groovy ci matrix from travis to gh actions.
mbien opened a new pull request, #4105:
URL: https://github.com/apache/netbeans/pull/4105
lets start with the great migration.
picked groovy as first target since it is already a nice matrix.
can we drop JDK 8? should we add 18? Lets see if it builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien closed pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien closed pull request #4105: migrate groovy ci matrix from travis to gh actions.
URL: https://github.com/apache/netbeans/pull/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872870548
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
@svenreimers awesome! If its of any help, thats my rough local test setup for experiments (this doesn't actually work due to some quotation issue, but you get the idea :)):
```bash
#!/bin/bash
set -e
export JAVA_HOME=/home/mbien/dev/java/jdk-11.0.15.9.1-corretto
export PATH=$JAVA_HOME/bin:$PATH
JMS_FLAGS=$(cat nbbuild/jms-config/base.flags nbbuild/jms-config/desktop.flags | xargs)
TEST_RUN_ARGS="-Dtest.run.args=\"--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming $JMS_FLAGS\""
OPTS="-Dtest-unit-sys-prop.ignore.random.failures=true $TEST_RUN_ARGS"
echo $OPTS
ant $OPTS -f groovy/groovy.editor test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872337654
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
can someone explain how the groovy tests actually work?
- what does `OPTS` do? I don't think anything is picking this env var up
- no JMS flags are set, which means this actually can't run on JDK 17 since it would fail with encapsulation exceptions
- JAVA_HOME is in fact correctly set but i can see in the travis log lines like `[nb-javac] Support for javac --release has been added in Java9 ignoring it which further indicates that this is running on JDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#issuecomment-1193152147
closed in favor of #4431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers commented on a diff in pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
svenreimers commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872866154
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
Having been involved in creating the groovy matrix I will try to find some time to dig into this... stay tuned..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#issuecomment-1124472297
```
2022-05-12T01:45:02.3774828Z [junit] Caused by: java.awt.HeadlessException:
2022-05-12T01:45:02.3775063Z [junit] No X11 DISPLAY variable was set, but this program performed an operation which requires it.
```
looks like groovy will need a X11 setup. Will add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872337654
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
can someone explain how the groovy tests actually work?
- what does `OPTS` do? I don't think anything is picking this env var up
- no JMS flags are set, which means this actually can't run on JDK 17 since it would fail with encapsulation exceptions
- `JAVA_HOME` is in fact correctly set but i can see in the travis log lines like `[nb-javac] Support for javac --release has been added in Java9 ignoring` it which further indicates that this is running on JDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4105: migrate groovy ci matrix from travis to gh actions.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4105:
URL: https://github.com/apache/netbeans/pull/4105#discussion_r872337654
##########
.travis.yml:
##########
@@ -593,60 +593,6 @@ matrix:
- ant $OPTS -f enterprise/websvc.editor.hints test
- ant $OPTS -f enterprise/websvc.websvcapi test
- ant $OPTS -f enterprise/websvc.wsstackapi test
-
- - name: Test groovy modules on Java 8
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 11
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 11 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
- - ant $TEST_OPTS -f groovy/groovy.gsp test
- #- ant $TEST_OPTS -f groovy/groovy.kit test
- - ant $TEST_OPTS -f groovy/groovy.support test
-
- - name: Test groovy modules on Java 17
- jdk: openjdk8
- env:
- - BUILD_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -quiet -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- - TEST_OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json -Dcluster.config=groovy -Djavac.compilerargs=-nowarn -Dbuild.compiler.deprecation=false -Dtest-unit-sys-prop.ignore.random.failures=true"
- before_script:
- - nbbuild/travis/ant.sh $BUILD_OPTS clean
- - nbbuild/travis/ant.sh $BUILD_OPTS build
- - wget https://raw.githubusercontent.com/sormuras/bach/master/install-jdk.sh
- - export TEST_JDK=`bash install-jdk.sh --feature 17 --license GPL --emit-java-home --silent | tail -1`
- - export OPTS="-Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json $OPTS -Dtest.nbjdk.home=$TEST_JDK -Dtest.run.args=--limit-modules=java.base,java.logging,java.xml,java.prefs,java.desktop,java.management,java.instrument,jdk.zipfs,java.scripting,java.naming -Dtest.bootclasspath.prepend.args=-Dno.netbeans.bootclasspath.prepend.needed=true"
- script:
- #- ant $TEST_OPTS -f groovy/groovy test
- #- ant $TEST_OPTS -f groovy/groovy.java test
- - ant $TEST_OPTS -f groovy/groovy.editor test
Review Comment:
can someone explain how the groovy tests actually work?
- what does `OPTS` do? I don't think anything is picking this env var up
- no JMS flags are set, which means this actually can't run on JDK 17 since it would fail with encapsulation exceptions
- `JAVA_HOME` is in fact correctly set but i can see in the travis log lines like `[nb-javac] Support for javac --release has been added in Java9 ignoring it` which further indicates that this is running on JDK 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists