You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/08/20 11:11:56 UTC

[GitHub] [drill] ihuzenko commented on a change in pull request #1844: DRILL-7326: Support repeated lists for CTAS parquet format

ihuzenko commented on a change in pull request #1844: DRILL-7326: Support repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r315631969
 
 

 ##########
 File path: exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java
 ##########
 @@ -268,10 +268,112 @@ public void writeField() throws IOException {
     consumer.endField(fieldName, fieldId);
   </#if>
     }
+
+    <#if mode.prefix == "Repeated">
+    /**
+     * Writing list field according to logical type rules
 
 Review comment:
   I'll drop the javadoc, intent is explained in parent one. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services