You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/14 05:45:20 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7951: ARROW-9716: [Rust] [DataFusion] Implement limit on concurrent threads in MergeExec

jorgecarleitao commented on a change in pull request #7951:
URL: https://github.com/apache/arrow/pull/7951#discussion_r470421892



##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -62,10 +62,31 @@ use crate::sql::{
 };
 use crate::table::Table;
 
+/// Configuration options for execution context
+#[derive(Copy, Clone)]
+pub struct ExecutionConfig {
+    /// Maximum number of concurrent threads for query execution
+    max_concurrency: usize,

Review comment:
       Isn't it simpler to make this value public instead of having `with_max_concurrency` as a setter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org