You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by "kezhuw (via GitHub)" <gi...@apache.org> on 2024/03/15 03:55:32 UTC
Re: [PR] ZOOKEEPER-4809: Fix do_completion use-after-free when log level is debug [zookeeper]
kezhuw commented on code in PR #2139:
URL: https://github.com/apache/zookeeper/pull/2139#discussion_r1525726768
##########
zookeeper-client/zookeeper-client-c/src/mt_adaptor.c:
##########
@@ -479,8 +480,9 @@ void *do_completion(void *v)
pthread_mutex_unlock(&zh->completions_to_process.lock);
process_completions(zh);
}
- api_epilog(zh, 0);
- LOG_DEBUG(LOGCALLBACK(zh), "completion thread terminated");
Review Comment:
Is it more conventional to swap the two statements ? I saw several `return api_epilog(zh, rc)` patterns. Also, line 460 has same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org