You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/10 14:35:12 UTC
[GitHub] [accumulo] milleruntime commented on a change in pull request #1918: Drop debug logs to trace in ZooLock
milleruntime commented on a change in pull request #1918:
URL: https://github.com/apache/accumulo/pull/1918#discussion_r573775847
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
##########
@@ -222,10 +222,7 @@ public int compare(String o1, String o2) {
}
});
}
- if (LOG.isDebugEnabled()) {
- LOG.debug("Children nodes: {}", validChildren.size());
- validChildren.forEach(c -> LOG.debug("- {}", c));
- }
+ LOG.trace("Children nodes (size: {}): {}", validChildren.size(), validChildren);
Review comment:
Here is what the logs look like now:
<pre>
2021-02-10T09:18:15,632 [zookeeper.ZooLock] DEBUG: validating and sorting children at path /accumulo/1791d843-ecd6-4a3b-85d8-19cfbeee854c/tservers/ip-10-113-12-25:10000
2021-02-10T09:18:15,632 [zookeeper.ZooLock] DEBUG: Children nodes: 1
2021-02-10T09:18:15,632 [zookeeper.ZooLock] DEBUG: - zlock#01437c1b-09a0-484a-8299-bf6562f9ae26#0000000000
2021-02-10T09:18:15,633 [zookeeper.ZooLock] DEBUG: validating and sorting children at path /accumulo/1791d843-ecd6-4a3b-85d8-19cfbeee854c/tservers/ip-10-113-12-25:10000
2021-02-10T09:18:15,633 [zookeeper.ZooLock] DEBUG: Children nodes: 1
2021-02-10T09:18:15,633 [zookeeper.ZooLock] DEBUG: - zlock#01437c1b-09a0-484a-8299-bf6562f9ae26#0000000000
</pre>
Here is what they look like on one line:
<pre>
2021-02-10T09:29:53,922 [zookeeper.ZooLock] DEBUG: Children nodes (size: 1): [zlock#47cb1017-5a01-4018-b6a2-4ca01a634136#0000000000]
2021-02-10T09:29:53,970 [zookeeper.ZooLock] DEBUG: Children nodes (size: 1): [zlock#850d0675-6d54-43fe-9d1b-7423c3e90998#0000000000]
</pre>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org