You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2015/10/27 08:28:29 UTC
Review Request 39679: FALCON-1559 Config changes required for native
scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39679/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1559
https://issues.apache.org/jira/browse/FALCON-1559
Repository: falcon-git
Description
-------
Some additional props and services need to be added to startup.properties to get native scheduler going.
Additionally fixed a bug that surfaced during cluster submission.
Diffs
-----
scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 67e047f
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java e400326
src/conf/startup.properties dc9e393
Diff: https://reviews.apache.org/r/39679/diff/
Testing
-------
Manual testing done.
Thanks,
Pallavi Rao
Re: Review Request 39679: FALCON-1559 Config changes required for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39679/#review104399
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Oct. 28, 2015, 4:32 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39679/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1559
> https://issues.apache.org/jira/browse/FALCON-1559
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Some additional props and services need to be added to startup.properties to get native scheduler going.
>
> Additionally fixed a bug that surfaced during cluster submission.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 67e047f
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java e400326
> src/conf/startup.properties dc9e393
>
> Diff: https://reviews.apache.org/r/39679/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 39679: FALCON-1559 Config changes required for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39679/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 4:32 a.m.)
Review request for Falcon.
Changes
-------
Addressed review comments
Bugs: FALCON-1559
https://issues.apache.org/jira/browse/FALCON-1559
Repository: falcon-git
Description
-------
Some additional props and services need to be added to startup.properties to get native scheduler going.
Additionally fixed a bug that surfaced during cluster submission.
Diffs (updated)
-----
scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 67e047f
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java e400326
src/conf/startup.properties dc9e393
Diff: https://reviews.apache.org/r/39679/diff/
Testing
-------
Manual testing done.
Thanks,
Pallavi Rao
Re: Review Request 39679: FALCON-1559 Config changes required for
native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Oct. 27, 2015, 7:26 p.m., pavan kumar kolamuri wrote:
> > src/conf/startup.properties, line 80
> > <https://reviews.apache.org/r/39679/diff/1/?file=1108800#file1108800line80>
> >
> > It should be org.apache.falcon.state.store.jdbc.JdbcStateStore right ?
Yep. Thats right. Thanks for catching it. Will update patch.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39679/#review104197
-----------------------------------------------------------
On Oct. 28, 2015, 4:32 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39679/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1559
> https://issues.apache.org/jira/browse/FALCON-1559
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Some additional props and services need to be added to startup.properties to get native scheduler going.
>
> Additionally fixed a bug that surfaced during cluster submission.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 67e047f
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java e400326
> src/conf/startup.properties dc9e393
>
> Diff: https://reviews.apache.org/r/39679/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 39679: FALCON-1559 Config changes required for
native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39679/#review104197
-----------------------------------------------------------
src/conf/startup.properties (line 80)
<https://reviews.apache.org/r/39679/#comment162488>
It should be org.apache.falcon.state.store.jdbc.JdbcStateStore right ?
- pavan kumar kolamuri
On Oct. 27, 2015, 7:28 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39679/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 7:28 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1559
> https://issues.apache.org/jira/browse/FALCON-1559
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Some additional props and services need to be added to startup.properties to get native scheduler going.
>
> Additionally fixed a bug that surfaced during cluster submission.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/state/store/AbstractStateStore.java 67e047f
> scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngineFactory.java e400326
> src/conf/startup.properties dc9e393
>
> Diff: https://reviews.apache.org/r/39679/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Pallavi Rao
>
>