You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/31 11:29:07 UTC

[GitHub] [flink] zentol commented on a diff in pull request #21153: [hotfix][runtime] Remove private methods

zentol commented on code in PR #21153:
URL: https://github.com/apache/flink/pull/21153#discussion_r1009309372


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/VoidNamespace.java:
##########
@@ -56,13 +54,4 @@ public boolean equals(Object obj) {
     public String toString() {
         return getClass().getSimpleName();
     }
-
-    // ------------------------------------------------------------------------
-    //  Singleton serialization
-    // ------------------------------------------------------------------------
-
-    // make sure that we preserve the singleton properly on serialization
-    private Object readResolve() throws ObjectStreamException {

Review Comment:
   This is wrong. https://docs.oracle.com/javase/7/docs/platform/serialization/spec/input.html#5903



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org