[GitHub] geode issue #631: GEODE-3051: Remove unreachable exception handling in Accep...

[WireBaron <gi...@git.apache.org>]

Github user WireBaron commented on the issue:

    https://github.com/apache/geode/pull/631
  
    Isn't it the same code handling the SSL handshake for both protocols right
    now? If it's a different code path, then we should probably add a new test
    for it.
    
    On Thu, Jul 13, 2017 at 8:37 AM, galen-pivotal <no...@github.com>
    wrote:
    
    > *@galen-pivotal* approved this pull request.
    >
    > It looks like CacheServerSSLConnectionDUnitTest.testNonSSLClient tests
    > that a client using the old client protocol gets an SSL exception. Do you
    > think it's worth making a test for the new protocol as well?
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/geode/pull/631#pullrequestreview-49818299>, or mute
    > the thread
    > <https://github.com/notifications/unsubscribe-auth/AQGwNsVsxyM0gKTQY25WiKBFDqHxrrv2ks5sNjmngaJpZM4OWXjN>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---